Repository navigation
Conversation
Splatting more than 32 values into `createinstance` allocates. For row types whose `createinstance` belongs to StructArrays or StaticArrays, build the row from the tuple of field values directly. Applies to scalar `getindex`, `pop!` and `popfirst!`. Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splatting more than 32 values into
createinstanceallocates. For row types whosecreateinstancebelongs to StructArrays or StaticArrays, build the row from the tuple of field values directly.Gets to zero allocations in operations like
nt[1]/pop!(nt)/sum(r -> r.x1, nt)/ ... for wide eltypes.Compared to #358: applies to both
getindex,pop!andpopfirst!, and to both tuples/namedtuples and staticarrays types.For custom structs, would need change to
createinstanceAPI that is public and already overloaded in other packages, so not doing that here. Very wide custom structs are quite rare anyways.