Skip to content

Fix portal-created service provider attribution #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Codecraft-Ops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix portal-created service provider attribution #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/routes/portal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ async def portal_create_service(
now = datetime.now(timezone.utc).isoformat()
service = {
"id": str(uuid.uuid4()),
"provider_id": provider.get("api_key_id") or provider["id"],
"provider_id": provider["id"],
"name": name,
"description": description,
"endpoint": endpoint,
Expand Down
32 changes: 32 additions & 0 deletions tests/test_portal_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,38 @@ def test_revoked_token_rejected(self, client, provider_account, db):
assert resp.status_code == 401 or resp.status_code == 403


class TestPortalServiceCreation:
def test_created_service_belongs_to_portal_provider(
self, client, provider_account, db
):
cookies = _session_cookie(provider_account["id"])
csrf = _get_csrf(client, cookies)

resp = client.post(
"/portal/services/create",
data={
"csrf_token": csrf,
"name": "Portal Test Service",
"description": "An external API created through the provider portal.",
"endpoint": "https://example.com/api",
"price_per_call": "0.05",
"free_tier_calls": "2",
"category": "data",
"service_type": "external",
},
cookies=cookies,
)

assert resp.status_code == 200
assert "Portal Test Service" in resp.text
with db.connect() as conn:
service = conn.execute(
"SELECT provider_id FROM services WHERE name = ?",
("Portal Test Service",),
).fetchone()
assert service["provider_id"] == provider_account["id"]


class TestSettingsPagePATDisplay:
def test_settings_shows_generate_button(self, client, provider_account):
cookies = _session_cookie(provider_account["id"])
Expand Down