Skip to content

feat: enhance permissions for workplace and academic supervisors in U… #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joshkovu merged 2 commits into from
May 1, 2026
Merged

feat: enhance permissions for workplace and academic supervisors in U… #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d6c2a
feat: enhance permissions for workplace and academic supervisors in U…
kdujordan May 1, 2026
17b5c44
Merge branch 'main' into fix/Unknown-intern
kdujordan May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions logify-backend/apps/accounts/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,25 @@ def get_object(self, pk):
return target
raise PermissionDenied("You can only view your assigned supervisors.")

if requester.role == User.WORKPLACE_SUPERVISOR:
is_assigned = (
InternshipPlacements.objects.filter(workplace_supervisor=requester)
.filter(intern=target)
.exists()
)
if is_assigned:
return target
raise PermissionDenied("You can only view interns assigned to you.")

if requester.role == User.ACADEMIC_SUPERVISOR:
is_assigned = (
InternshipPlacements.objects.filter(academic_supervisor=requester)
.filter(intern=target)
.exists()
)
if is_assigned:
return target
raise PermissionDenied("You can only view interns assigned to you.")
if requester.role == User.ACADEMIC_SUPERVISOR:
if target.role == User.STUDENT:
if InternshipPlacements.objects.filter(
Expand Down
Loading