Repository navigation
chore: retire the old path's deploy workflows, which no repository calls - #213
Merged
Merged
Conversation
Every Project is delivered through the estate now, so nothing on main still calls the deploy-config-schema workflows; the retired repos that do pin them by SHA.
1 of 2 tasks
ExtraToast
added a commit
to JorisJonkers-dev/repo-template
that referenced
this pull request
Nov 1, 2026
The input validated platform configs with deploy-config-schema, which github-workflows no longer carries (JorisJonkers-dev/github-workflows#213). It is optional at the pinned v0.7.3, so dropping it changes nothing there and keeps the template valid on the next pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Project is now delivered through the estate (an Intent Fragment from
publish-fragment.yml, composed by deploy-kit), so the old path that renderedplatform/deploy-config with@jorisjonkers-dev/deploy-config-schemahas no callers on any active repository'smain(the last calls went in JorisJonkers-dev/auth-api#134, JorisJonkers-dev/auth-ui#62, JorisJonkers-dev/home-portal#102, JorisJonkers-dev/stalwart-provisioner#43, JorisJonkers-dev/tribelt#49 and JorisJonkers-dev/repo-template#38). The only callers left are retired repositories (agent-runtime, agents-api, agents-ui, knowledge) that pin these workflows by commit SHA, so removing them here breaks nothing. This is what letsdeploy-config-schemabe archived.Removed:
deploy-artifact.yml,deploy-bundle.yml,deploy-config-render-drift.yml,deploy-sources-render.yml,deploy-validate.ymlandplatform-config-validate.yml.deploy-artifact,deploy-bundle,deploy-config-render-drift,deploy-preview,deploy-sources-renderandplatform-config-validate.tools/deploy-check, which onlydeploy-artifactanddeploy-previewran. Its CI job (Deploy Check Tests, whichPipeline Completeneeded) and the release job that published@jorisjonkers-dev/deploy-checkgo with it.tests/test_deploy_actions_cli_drift.py,tests/fixtures/deploy-artifact/andtests/test_raw_manifests_unsupported.py, plus the assertions intest_crac_train_workflow.py,test_deploy_platform_d.pyandtest_workflow_job_timeouts.pythat only covered removed files. The leak-scan, Renovate, compose, CI and node-ci coverage in those files stays.extra-filesentries, the README rows and examples, the tool-pinning note indocs/action-pinning.md, and the.gitignoreline.gitops-ci.ymlkeepsoverlay-paths, the Flux render validation and the optional system tests. It losesplatform-config-paths,deploy-config-command,deploy-config-targets, thepackages-tokensecret,packages: read, and the platform-config and render-drift steps. The repo-template template pinsgitops-ci.yml@v0.7.3and still passesplatform-config-paths, so it has to drop that input when it moves to this release.Test plan
python3 -m unittest discover -s tests: 258 tests pass. 18 tests went with the removed files.check_migrationscoverage gate passes locally at 91%, against a floor of 80.actionlint .github/workflows/*.ymlis clean.yaml.safe_load.deploy-config-schema,deploy-artifact,deploy-bundle,deploy-validate,platform-config-validate,deploy-sources-render,deploy-config-render-drift,cluster-deploy-context,deploy-preview,deploy-check) finds nothing outsideCHANGELOG.md.Pipeline Complete, and that job stays.