Skip to content

chore: retire the old path's deploy workflows, which no repository calls - #213

Merged
ExtraToast merged 1 commit into
mainfrom
chore/retire-old-deploy-path
Nov 1, 2026
Merged

ExtraToast merged 1 commit into
mainfrom
chore/retire-old-deploy-path

Conversation

@ExtraToast

Copy link
Copy Markdown
Contributor

Summary

Every Project is now delivered through the estate (an Intent Fragment from publish-fragment.yml, composed by deploy-kit), so the old path that rendered platform/ deploy-config with @jorisjonkers-dev/deploy-config-schema has no callers on any active repository's main (the last calls went in JorisJonkers-dev/auth-api#134, JorisJonkers-dev/auth-ui#62, JorisJonkers-dev/home-portal#102, JorisJonkers-dev/stalwart-provisioner#43, JorisJonkers-dev/tribelt#49 and JorisJonkers-dev/repo-template#38). The only callers left are retired repositories (agent-runtime, agents-api, agents-ui, knowledge) that pin these workflows by commit SHA, so removing them here breaks nothing. This is what lets deploy-config-schema be archived.

Removed:

  • Reusable workflows deploy-artifact.yml, deploy-bundle.yml, deploy-config-render-drift.yml, deploy-sources-render.yml, deploy-validate.yml and platform-config-validate.yml.
  • Actions deploy-artifact, deploy-bundle, deploy-config-render-drift, deploy-preview, deploy-sources-render and platform-config-validate.
  • tools/deploy-check, which only deploy-artifact and deploy-preview ran. Its CI job (Deploy Check Tests, which Pipeline Complete needed) and the release job that published @jorisjonkers-dev/deploy-check go with it.
  • tests/test_deploy_actions_cli_drift.py, tests/fixtures/deploy-artifact/ and tests/test_raw_manifests_unsupported.py, plus the assertions in test_crac_train_workflow.py, test_deploy_platform_d.py and test_workflow_job_timeouts.py that only covered removed files. The leak-scan, Renovate, compose, CI and node-ci coverage in those files stays.
  • The release-please extra-files entries, the README rows and examples, the tool-pinning note in docs/action-pinning.md, and the .gitignore line.

gitops-ci.yml keeps overlay-paths, the Flux render validation and the optional system tests. It loses platform-config-paths, deploy-config-command, deploy-config-targets, the packages-token secret, packages: read, and the platform-config and render-drift steps. The repo-template template pins gitops-ci.yml@v0.7.3 and still passes platform-config-paths, so it has to drop that input when it moves to this release.

Test plan

  • python3 -m unittest discover -s tests: 258 tests pass. 18 tests went with the removed files.
  • The check_migrations coverage gate passes locally at 91%, against a floor of 80.
  • actionlint .github/workflows/*.yml is clean.
  • All 41 remaining YAML files parse with yaml.safe_load.
  • The old-path grep (deploy-config-schema, deploy-artifact, deploy-bundle, deploy-validate, platform-config-validate, deploy-sources-render, deploy-config-render-drift, cluster-deploy-context, deploy-preview, deploy-check) finds nothing outside CHANGELOG.md.
  • The ruleset's only required check is Pipeline Complete, and that job stays.

Every Project is delivered through the estate now, so nothing on main still
calls the deploy-config-schema workflows; the retired repos that do pin them by SHA.
@ExtraToast ExtraToast added type: chore Maintenance work without intended behavior change. area: tooling Reusable workflows, Gradle, templates, Renovate, and API tooling. labels Nov 1, 2026
@ExtraToast
ExtraToast merged commit 61b0640 into main Nov 1, 2026
5 checks passed
@ExtraToast
ExtraToast deleted the chore/retire-old-deploy-path branch November 1, 2026 21:45
ExtraToast added a commit to JorisJonkers-dev/repo-template that referenced this pull request Nov 1, 2026
The input validated platform configs with deploy-config-schema, which
github-workflows no longer carries (JorisJonkers-dev/github-workflows#213). It is
optional at the pinned v0.7.3, so dropping it changes nothing there and keeps
the template valid on the next pin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tooling Reusable workflows, Gradle, templates, Renovate, and API tooling. type: chore Maintenance work without intended behavior change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant