Repository navigation
fix: publish fragments with deploy-kit 0.28.0 - #193
Merged
Merged
Conversation
deploy-kit 0.28.0 has a Platform document name each privileged role's holder as <project>/<application> (JorisJonkers-dev/deploy-kit#539). The estate's Platform fragment is validated here with the platform beside the fragments it names, and 0.26.1 links those references by bare id, so it refuses the new form.
ExtraToast
added
type: bug
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-fragmentvalidates and packs every Intent Fragment with the deploy-kittools/deploy-kitpins. deploy-kit 0.28.0 has a Platform document name each privileged role's holder as<project>/<application>(JorisJonkers-dev/deploy-kit#539). 0.26.1 links those fields by bare Application id, so it would refuse the estate's Platform fragment once it moves to the new form. A project file's format is unchanged, so every other fragment validates as before.tools/deploy-kit/package.jsonand its lockfile move to 0.28.0.Note
deploy-kit's
engines.nodereadsv26.12.1since 0.27.1 (a Renovate pin, JorisJonkers-dev/deploy-kit#64), whilepublish-fragmentruns Node 24. npm only warns about that, and the estate already composes with 0.27.1 on Node 24. The pin itself is being fixed in deploy-kit.Order: this release, then the estate's
release.ymlmoves to it with itstoolkit.ymlat 0.28.0 and its Platform document rewritten, in one PR.