Repository navigation
feat(model): refuse a fragment written at a model version the toolkit does not read - #670
Merged
Merged
Conversation
… does not read Composition admitted every fragment whatever schemaVersion it was written at, so a fragment at a newer minor composed with the fields the toolkit could not read dropped, and the run exited zero. A participant whose fragment is at another major, or at a newer minor than the toolkit's, is now E_SCHEMA_VERSION_MISMATCH: isolated at the fragment it last composed at, dormant or not, and a Platform document at such a version stops the run. A patch difference never gates. Where the fragment a Project would be held or rolled back at is itself one the toolkit cannot read, the run stops too, since composing it would drop the same fields. The toolkit's model version is release-please's to set, beside package.json, so the range moves with every release. Closes #665
ExtraToast
enabled auto-merge (squash)
October 27, 2026 14:02
Shape
CoverageBaseline:
Lines this pull request changed: 23/23 covered (100.00%). |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Composition now refuses a fragment written at a model version the toolkit cannot read, so a newer fragment can no longer compose with its new fields silently dropped.
E_SCHEMA_VERSION_MISMATCH. A patch difference never gates.SCHEMA_VERSIONcarriesx-release-please-version, andsrc/cli/main.tsis listed inextra-files, so release-please writes it besidepackage.json. chore(main): release 1.0.0 #631 writes1.0.0(the cut'sRelease-As), so nothing changes before 1.0.0.lint-codes.Decided here
Test plan
npm run verify(2480 tests)SCHEMA_VERSION, not a literal, so a 1.1.0 release PR stays greenPart of #195.
Closes #665