Repository navigation
feat(model): name the member that serves a native Client's protected path - #630
Merged
Merged
Conversation
…path The release-gate inputs carry protectedBy, the Process the longest Route of the Client's exposure takes protectedPath to, so the Release Gate asks the member the edge would. A path no Route reaches, or one that reaches a Process with no readiness, is E_CLIENT_PATH_UNROUTED. Closes #629.
ExtraToast
enabled auto-merge (squash)
October 26, 2026 06:32
Shape
CoverageBaseline:
Lines this pull request changed: 21/21 covered (100.00%). |
…member # Conflicts: # spec/v1/examples/identity/expected/resolved.grafana.json # spec/v1/examples/identity/expected/resolved.portal.json # spec/v1/examples/identity/rendered/apps/identity/grafana/canary.yaml # spec/v1/examples/identity/rendered/apps/identity/grafana/vso.yaml # spec/v1/examples/identity/rendered/apps/identity/portal/canary.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629. Part of #429.
Summary
E_CLIENT_OPENis the Release Gate's anonymous request to a native Client'sprotectedPath. The inputs carried the path but not which member serves it. A static UI member answers any path with its index page, so asking the wrong member, or every member, would hold a sound release. By the maintainer's choice, the member is the one the edge itself would send the request to.protectedBy. BesideprotectedPath, the release-gate inputs name the Process the longest matching Route of the Client's exposure takes the path to.prefixRoute matches a path it opens, anexactone the path itself, and a redirect Route reaches no Process.routeForinproject-intent-queries.tsis the one place this is decided, for the check and the resolution alike.E_CLIENT_PATH_UNROUTED, atclient/protectedPath: no Route of the Client's exposure reaches the path, or the Route that does reaches a Process that publishes no readiness, so the gate could not ask it. A Route to a Process the Application lacks is left toE_UNKNOWN_PROCESS.protectedBy.protectedBymember which did not change in the release is not asked.refusals/client-path-unrouted/, with its diagnostics oracle and README row.protectedBy, inresolved.jsonand in their release-gate ConfigMaps. Revisions follow.To know
emf/is frozen atmde-task-3.protectedByonce delivery vendors a deploy-kit ref that has it.Checks
/.auth/case now also routes/api/.