Repository navigation
feat: serve the sign-in UI from the unprivileged nginx on 8080 - #57
Merged
Merged
Conversation
The estate path runs every container non-root, on a read-only root filesystem with no capabilities (JorisJonkers-dev/auth-api#80). nginx:alpine runs as root and binds 80, so it would never start there. The unprivileged nginx runs as uid 101, keeps its pid and temp files under /tmp, and listens on 8080, as home-portal's does.
Deploy Preview — auth-uiEnvironments: production Image refs
SC-11 Readiness Scorecard
Updated by deploy-check on push to this PR. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of JorisJonkers-dev/auth-api#80 (epic JorisJonkers-dev/estate#204).
The estate path runs every container non-root, on a read-only root filesystem with no capabilities, and deploy-kit 0.31 renders the images lock's uid beside
runAsNonRoot: true.nginx:alpineruns as root and binds 80, so the current image never starts there.FROM nginxinc/nginx-unprivileged:alpine: uid 101, pid and temp files under/tmp, as home-portal's image.listen 8080,EXPOSE 8080;platform/deployment.yml's health port follows.Checked locally: the built image, run as
--user 101:101 --read-only --tmpfs /tmp --cap-drop ALL, answers 200 on/and/login.Release order: merge and release this only after fleet-infra's two auth handover PRs have reconciled (orphan, then drop). Before that, fleet-infra's auto-bump would pin this image into the old path's Deployment, which still declares port 80. Then release this before auth-api, whose publish locks auth-ui's latest release. Runbook: JorisJonkers-dev/estate
docs/runbooks/auth-handover.md.