Repository navigation
fix(deploy): validate the project file with its env files when publishing - #121
Merged
Merged
Conversation
…hing
On deploy-kit 1.0 the auth-api Process's transit grant needs the Vault client its env file wires (${identity:vaultRole}). Publish Fragment validated the project file alone, so the v0.21.0 fragment was refused with E_SELF_WITHOUT_VAULT_CLIENT and never published.
Part of #119
ExtraToast
added
type: bug
ExtraToast
enabled auto-merge (squash)
October 27, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.21.0's fragment never published. Publish Fragment validated
deploy/auth.project.ymlon its own, and on deploy-kit 1.0 that file alone is refused: theauth-apiProcess's transit grant needs the Vault client thatdeploy/env/auth-api/base.envwires with${identity:vaultRole}.validate-with: deploy/envmakes the workflow read the env files together with the project file, as the pack step already does.Test plan
deploy-kit validate deploy/auth.project.ymlon 1.0.0:E_SELF_WITHOUT_VAULT_CLIENT, which is the failure from run 40527227240deploy-kit validate deploy/auth.project.yml deploy/envon 1.0.0:accepted (3 read)schemaVersion1.0.0Part of JorisJonkers-dev/deploy-kit#195. Part of #119.