Skip to content

Drop the per-PR repository hygiene gate from the private repos #34

Closed
Closed
Drop the per-PR repository hygiene gate from the private repos#34
Labels
area: toolingReusable workflows, Gradle, templates, Renovate, and API tooling.component: ciContinuous integration workflow or check behavior.governanceRepo protection, permissions, visibilitypriority: P2Medium; normal planned work.type: choreMaintenance work without intended behavior change.

Description

@ExtraToast
ExtraToast
opened on Aug 27, 2026

What to build

Once the org-wide hygiene sweep is running on a public runner, remove the per-PR repository-hygiene.yml shim from the private repos it covers — fleet-infra and nix-config — for ~292 billable minutes/month.

Only remove the gate from repos the sweep genuinely covers, and only where the sweep's advisory posture was accepted in the parent ticket. Any repo that keeps hygiene as a blocking requirement keeps its shim.

Removing the workflow is not sufficient on its own: if Repository Hygiene is a required status check in a repo's ruleset, deleting the workflow leaves pull requests permanently unmergeable waiting for a context nothing will ever report. Update the ruleset in the same change.

Acceptance criteria

  • repository-hygiene.yml removed only from repos the sweep covers and where advisory was accepted
  • Repository Hygiene removed from the required status checks of every ruleset that named it
  • A PR opened in each affected repo merges cleanly without waiting on a missing context — verify on a real PR
  • Hygiene violations in those repos are still surfaced by the sweep

Blocked by

Activity

  1. ExtraToast
    added
    type: choreMaintenance work without intended behavior change.
    area: toolingReusable workflows, Gradle, templates, Renovate, and API tooling.
    component: ciContinuous integration workflow or check behavior.
    priority: P2Medium; normal planned work.
    governanceRepo protection, permissions, visibility
    on Aug 27, 2026

  2. ExtraToast commented on Aug 27, 2026

    @ExtraToast
    ExtraToast
    on Aug 27, 2026
    ContributorAuthor

    Correction: the ruleset risk this issue describes does not exist.

    The issue says removing the workflow would leave PRs unmergeable waiting on a required context, and to update the ruleset in the same change. No ruleset change is needed — Repository Hygiene was never a required check:

    fleet-infra Main  -> required contexts: Pipeline Complete
nix-config  Main  -> required contexts: Pipeline Complete
GET /repos/{r}/branches/main/protection -> 404 Branch not protected  (both)

    That also removes the 'advisory vs blocking' trade-off from the decision entirely — the guard already only reported. This is a clean ~292 min/month with nothing given up.

    PRs: JorisJonkers-dev/fleet-infra#164 and JorisJonkers-dev/nix-config#28, plus the caller in #37. Each repo should come off the sweep's exclude-repos list when its PR merges.

  3. ExtraToast
    added a commit that references this issue on Aug 29, 2026

    feat(hygiene): schedule the advisory org hygiene sweep from a public …

    1c18fa1

  4. ExtraToast commented on Aug 29, 2026

    @ExtraToast
    ExtraToast
    on Aug 29, 2026
    ContributorAuthor

    Done, and wider than this issue scoped. The per-PR guard is removed from fleet-infra#164, nix-config#28 and homelab-collections#14 — that last one was missed by this issue, which named only two repos, and was found by listing every private repo's active workflows rather than trusting the ticket.

    No ruleset change was needed: Repository Hygiene was never a required check anywhere, so nothing was given up.

    Follow-up landed in #41: fleet-infra and nix-config came off the sweep's exclude-repos list in the same breath, since the sweep is now their only hygiene coverage and leaving them excluded would have left them silently unchecked.

    Hygiene sweep verified in production: 28 repos / 29 open PRs / 0 offenders before #41, 30 repos after.

  5. ExtraToast
    closed this as completedon Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: toolingReusable workflows, Gradle, templates, Renovate, and API tooling.component: ciContinuous integration workflow or check behavior.governanceRepo protection, permissions, visibilitypriority: P2Medium; normal planned work.type: choreMaintenance work without intended behavior change.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions