Default flag-format#40
Open
eljeffeg wants to merge 1 commit into
Open
Conversation
This checks to see if any flag-format has been provided and instead of failing with an exception, sets a standard default format, such as `FLAG{my_flag}`.
BillWeiss
reviewed
Mar 14, 2022
| self.register_cmdfinalization_hook(self.finalization_hook) | ||
|
|
||
| # Set a default flag-format if none supplied | ||
| if self.manager.flag_pattern is None: |
There was a problem hiding this comment.
Dumb question: shouldn't this be self.manager.flag_format?
Contributor
Author
There was a problem hiding this comment.
It's possible that would also work. flag_pattern is the compiled regex of flag_format, so when flag_format is set using manager, flag_pattern is also being set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks to see if any flag-format has been provided and instead of failing with an exception, sets a standard default format of
S+{.*?}. Prints a message to the user that it's using a default flag format.This allows you to just run
$ katanaafter install without any configuration errors / issues, bringing you to the prompt where you could set the flag-format if you need to, rather than requiring it from the command arg or ini.