Merged
Conversation
Still failures, and overall not happy with the actual test layouts, but that'll come later.
Easier to just edit the registry for that test anyway.
Still requires some kludge to spy the created objects because of how Paper constructs plugins, but such is life.
Don't need a sketchy generic test casting a function to a bifunction
Clean up some inspection issues Bump version to 5.0.0-SNAPSHOT because things will break
Not sure what to do about runnable - can't mock .equals, unfortunately.
Closed
|
❌ The last analysis has failed. |
Need to expand property before tests can run
I guess when I recreated the project after it got deleted the ID generated in lower case. Whoops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiles and tests pass, but still needs some work.