Fix OpenMP linkage on Linux - #12
Open
ravila4 wants to merge 1 commit into
Open
Conversation
Author
|
I believe this is related to issue: #11 I was able to observe the change in performance before and after the fix: Current behavior (built from main): After restoring OpenMP linkage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux builds were not enabling OpenMP for GCTA targets, causing OpenMP regions to run serially.
The regression was introduced in 405cf943, which removed the global
-fopenmpcompile option while retainingOpenMP::OpenMP_CXXlinkage only inside the macOS branch.This change links
OpenMP::OpenMP_CXXto all GCTA targets on supported platforms, preserving the existing macOS behavior and restoring OpenMP on Linux.Validation
--joint-covar: 1,818 s to 225 s (8.08x)--joint-covar: 1,081 s to 145 s (7.46x)