fix: return svg response for streak rate limit#2210
Closed
lowkeyd3v wants to merge 2 commits into
Closed
Conversation
|
👋 Hey @lowkeyd3v, welcome to CommitPulse! 🎉 Thanks for opening your first pull request — this is a big deal and we appreciate the effort! While you wait for a review, please double-check:
A maintainer will review your PR shortly. Hang tight! 🚀 |
|
🚨 Hey @lowkeyd3v, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Contributor
|
@lowkeyd3v is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2207
This PR fixes inconsistent rate-limit behavior for
/api/streak.Previously, when
/api/streakexceeded the middleware rate limit, the response returned JSON (application/json) even though the endpoint is intended to be consumed as an SVG image badge.Changes made
Added a special-case for
/api/streakinsidemiddleware.tsReturn
image/svg+xmlon429 Too Many RequestsPreserve existing JSON rate-limit behavior for other API routes
Preserve rate-limit headers:
X-RateLimit-LimitX-RateLimit-RemainingX-RateLimit-ResetVerification
Tested locally by sending repeated requests to:
/api/streak?user=octocatAfter exceeding the rate limit, the endpoint returned:
This keeps badge embeds SVG-compatible instead of returning a JSON response.
Pillar
🐞 Bug Fix
Checklist