fix(api): classify compare route GitHub errors#2205
Merged
JhaSourav07 merged 1 commit intoJun 1, 2026
Conversation
Contributor
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
/addlabel bug api gssoc26 |
Aamod007
approved these changes
Jun 1, 2026
|
🎉 Congratulations @eshaanag! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2204
Pillar
What changed
The
/api/compareroute usedPromise.allSettled, but both rejected fetch branches returned404unconditionally. That made GitHub rate limits and upstream failures look like missing users.This PR adds a small helper that classifies rejected GitHub dashboard fetches before responding:
404403with the existing GitHub rate-limit message500instead of being mislabeled as not-foundTests were added for user1 rate-limit, user2 rate-limit, and a non-rate-limit upstream failure.
Visual Preview
N/A - JSON API status-code fix only.
Local verification
npm run test -- app/api/compare/route.test.tspassednpm run format:checkpassednpm run lintpassed with one existing warning incomponents/WallOfLove.tsxnpm run typecheckpassednpm run testpassed: 83 files, 1438 passed, 1 expected failnpm run buildfails locally with an opaque webpack error; this appears environment/upstream-local because CI build passed on the prior PR after the same local failure patternGSSoC 2026
This is raised and fixed under GSSoC 2026. Please add the relevant GSSoC/level labels if they do not sync from the issue automatically.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run format/npm run format:checkandnpm run lintlocally.npm run testand all tests pass locally.README.mdif I added a new theme or URL parameter.