Skip to content

fix: add input validation and rate limiting to /api/compare endpoint #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 4 commits into from
Jun 1, 2026
Merged

fix: add input validation and rate limiting to /api/compare endpoint #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
341ec70
fix: add input validation and rate limiting to /api/compare endpoint
vipul674 May 31, 2026
c178060
style: fix prettier formatting in validations.ts
vipul674 May 31, 2026
88ed0e5
fix: remove duplicate compareParamsSchema after upstream merge
vipul674 Jun 1, 2026
b0cc9ce
fix: align compareParamsSchema refine message with test expectation
vipul674 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions lib/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,26 @@ export const githubParamsSchema = z.object({
refresh: z.string().optional().transform(toRefreshFlag),
});

export const compareParamsSchema = z
.object({
user1: z
.string({ error: 'Missing "user1" parameter' })
.trim()
.min(1, { message: 'user1 is required' })
.max(39, { message: 'GitHub username cannot exceed 39 characters' })
.regex(GITHUB_USERNAME_REGEX, { message: 'Invalid GitHub username for user1' }),
user2: z
.string({ error: 'Missing "user2" parameter' })
.trim()
.min(1, { message: 'user2 is required' })
.max(39, { message: 'GitHub username cannot exceed 39 characters' })
.regex(GITHUB_USERNAME_REGEX, { message: 'Invalid GitHub username for user2' }),
})
.refine((data) => data.user1.toLowerCase() !== data.user2.toLowerCase(), {
message: 'Cannot compare a user with themselves.',
path: ['user2'],
});

export const ogParamsSchema = z
.object({
user: z.string().trim().optional().transform(toEmptyStringAsUndefined),
Expand Down Expand Up @@ -453,26 +473,6 @@ export const wrappedParamsSchema = z.object({
height: dimensionParam('height', 80, 800),
});

export const compareParamsSchema = z
.object({
user1: z
.string({ error: 'Missing user1 parameter' })
.trim()
.min(1, { message: 'user1 is required' })
.max(39, { message: 'GitHub username cannot exceed 39 characters' })
.regex(GITHUB_USERNAME_REGEX, { message: 'Invalid GitHub username for user1' }),
user2: z
.string({ error: 'Missing user2 parameter' })
.trim()
.min(1, { message: 'user2 is required' })
.max(39, { message: 'GitHub username cannot exceed 39 characters' })
.regex(GITHUB_USERNAME_REGEX, { message: 'Invalid GitHub username for user2' }),
})
.refine((data) => data.user1.toLowerCase() !== data.user2.toLowerCase(), {
message: 'Cannot compare a user with themselves.',
path: ['user2'],
});

export const notifyPostSchema = z.object({
username: z
.string({ error: 'Username is required.' })
Expand Down
1 change: 1 addition & 0 deletions middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@ export const config = {
'/api/stats/:path*',
'/api/og/:path*',
'/api/notify/:path*',
'/api/compare/:path*',
],
};
Loading