Skip to content

test(ComparisonStatsCard): verify icon renders correctly for all supported icon names (#1069)#1976

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
Master-Bruce-Wayne:test/icon-rendering
May 31, 2026
Merged

test(ComparisonStatsCard): verify icon renders correctly for all supported icon names (#1069)#1976
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
Master-Bruce-Wayne:test/icon-rendering

Conversation

@Master-Bruce-Wayne
Copy link
Copy Markdown
Contributor

Description

Fixes #1069

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

The tests are running fine as tested -
Screenshot 2026-05-31 102257

Copilot AI review requested due to automatic review settings May 31, 2026 06:08
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

@Master-Bruce-Wayne is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds 8 icon rendering tests for ComparisonStatsCard — verifies each lucide icon (Flame, TrendingUp, GitCommit, GitBranch, Users, UserPlus, Award) and unknown fallback render an SVG. 23/23 tests pass, no deletions, no blocking labels.

@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels May 31, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone May 31, 2026
@JhaSourav07 JhaSourav07 merged commit 693065a into JhaSourav07:main May 31, 2026
10 of 11 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Congratulations @Master-Bruce-Wayne! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ComparisonStatsCard): verify icon renders correctly for all supported icon names

3 participants