test(validations): add comprehensive org parameter validation tests#1971
Merged
JhaSourav07 merged 1 commit intoMay 31, 2026
Merged
Conversation
Contributor
|
@sodium16 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod007
requested changes
May 31, 2026
Collaborator
Aamod007
left a comment
There was a problem hiding this comment.
This PR replaces (deletes) the existing returns 400 when the user parameter is missing test which verified the error response structure (body.error, body.details). The remaining does not hit the GitHub API when user is missing only checks that fetch isn't called — it doesn't assert the response body format.
Please keep the missing user test and add the org validation test alongside it instead of replacing it.
Owner
|
please see the mentor comment and fix it so that i can merge your PR |
7bb89cd to
86390b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1429
Pillar
Visual Preview
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.