Skip to content

test(validations): add comprehensive org parameter validation tests#1971

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
sodium16:test/org-parameter-validation
May 31, 2026
Merged

test(validations): add comprehensive org parameter validation tests#1971
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
sodium16:test/org-parameter-validation

Conversation

@sodium16
Copy link
Copy Markdown
Contributor

Description

Fixes #1429

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

Copilot AI review requested due to automatic review settings May 31, 2026 05:54
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

@sodium16 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces (deletes) the existing returns 400 when the user parameter is missing test which verified the error response structure (body.error, body.details). The remaining does not hit the GitHub API when user is missing only checks that fetch isn't called — it doesn't assert the response body format.

Please keep the missing user test and add the org validation test alongside it instead of replacing it.

@JhaSourav07
Copy link
Copy Markdown
Owner

@sodium16

please see the mentor comment and fix it so that i can merge your PR

@sodium16 sodium16 force-pushed the test/org-parameter-validation branch from 7bb89cd to 86390b3 Compare May 31, 2026 08:07
@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels May 31, 2026
@JhaSourav07 JhaSourav07 merged commit 668316d into JhaSourav07:main May 31, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(api validation): check query validation boundaries for ?org= parameter (Variation 1)

3 participants