Skip to content

test(api validation): check query validation boundaries for ?accent= parameter (Variation 4)#1958

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
boss477:fix/issue-1458
May 31, 2026
Merged

test(api validation): check query validation boundaries for ?accent= parameter (Variation 4)#1958
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
boss477:fix/issue-1458

Conversation

@boss477
Copy link
Copy Markdown
Contributor

@boss477 boss477 commented May 31, 2026

Description

Fixes #1458

This PR adds unit tests and route integration tests to verify validation boundaries for the ?accent= query parameter when passing an invalid color hex value like #ZZZZZZ.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

None (Validation changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

@boss477 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the missing expect(response.status).toBe(400) to the existing #ZZZZZZZ route test (which was a no-op) and adds the complementary #ZZZZZZ (6-char, all non-hex) boundary test at both the schema and route layers. 220/220 tests pass. Clean and focused.

@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels May 31, 2026
@JhaSourav07 JhaSourav07 merged commit fe4eab5 into JhaSourav07:main May 31, 2026
9 of 10 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone May 31, 2026
@github-actions
Copy link
Copy Markdown

🎉 Congratulations @boss477! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(api validation): check query validation boundaries for ?accent= parameter (Variation 4)

3 participants