Skip to content

test(streak route): verify SVG viewBox output#1953

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
mayank200529:test-streak-route-svg-viewbox
May 31, 2026
Merged

test(streak route): verify SVG viewBox output#1953
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
mayank200529:test-streak-route-svg-viewbox

Conversation

@mayank200529
Copy link
Copy Markdown
Contributor

Description

Fixes #699

Added assertions to verify that the SVG response generated by the streak route contains:

  • viewBox attribute for proper SVG scaling
  • xmlns="http://www.w3.org/2000/svg" namespace declaration

This helps ensure generated badges remain valid SVGs and scale correctly in GitHub READMEs and other embedding contexts.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Not applicable — test-only change.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

@mayank200529 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mayank200529
Copy link
Copy Markdown
Contributor Author

@JhaSourav07 please check the authorization of vecel part

@JhaSourav07 JhaSourav07 merged commit ab0b44d into JhaSourav07:main May 31, 2026
5 of 6 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Congratulations @mayank200529! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels May 31, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(streak route): verify SVG output contains the viewBox attribute

3 participants