Skip to content

Restore bounded passive chat auto-open - #361

Merged
danyaberezun merged 3 commits into
mainfrom
olga.lavrichenko/chat-auto-open
Sep 1, 2026
Merged

Restore bounded passive chat auto-open#361
danyaberezun merged 3 commits into
mainfrom
olga.lavrichenko/chat-auto-open

Conversation

@OLavrik

Copy link
Copy Markdown
Collaborator

On workspace entry, up to 4 unplaced sessions that are still live or carry open todos auto-open (newest first); if nothing is placed and nothing qualifies, the single most-recent session opens as a fallback
so a workspace never lands empty while chat history exists. Everything else stays in history for explicit reopen.

  • Latched at module scope per (workspaceId, connectionGeneration), not a per-mount ref — WorkspaceWorkbench remounts on every workspace switch and the catalog effect re-fires on every commit identity
    change, so a ref-based latch would forget a spent attempt.
  • An exact-chat route target (deep link) defers passive auto-open entirely for that pass, so an unrelated live chat can't win the group's selection out from under the link the surface was asked to land on.
  • Recorded as architecture.md Decision add "discuss first" #8; updates the 12 e2e specs whose expectations assumed no auto-open.

Comment thread apps/web/src/shell/chatReconciliation/chatReconciliation.ts Outdated
@OLavrik
Olga Lavrichenko (OLavrik) force-pushed the olga.lavrichenko/chat-auto-open branch from 2747062 to 617fcb2 Compare September 1, 2026 01:19

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes — please address the blocking inline finding.

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — ready to merge.

@danyaberezun
danyaberezun added this pull request to the merge queue Sep 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 1, 2026
@danyaberezun
danyaberezun added this pull request to the merge queue Sep 1, 2026

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — ready to merge.

Merged via the queue into main with commit 756a4b8 Sep 1, 2026
6 checks passed
@danyaberezun
danyaberezun deleted the olga.lavrichenko/chat-auto-open branch September 1, 2026 18:38
jetbrains-air Bot pushed a commit that referenced this pull request Sep 1, 2026
Resolve the import-block conflict in e2e/chat-order.spec.ts as the union of
both sides: main (#361) dropped `openChatFromHistory` when passive chat
auto-open removed its last two call sites, and this branch's
`./fixtures/chatScroll` helpers are kept for the new latest-edge assertions.

Produced by AIR Automations. Name: Resolve Merge Conflicts / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/6019d7e8-25e2-42ee-9589-26da37839744?run=bd701a8c-f5c1-49c5-b411-b223a0750a83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants