fix(web): open assistant workspace links in-app - #351
Open
Rinat S (rsolmano) wants to merge 9 commits into
Open
Conversation
ThinkRail-Todo: 01a052bd-94dc-7921-b0ce-d561c74f094a/t_80a9b99c517a
ThinkRail-Todo: 01a052bd-94dc-7921-b0ce-d561c74f094a/t_94aa4f1bf4cf
ThinkRail-Todo: 01a052bd-94dc-7921-b0ce-d561c74f094a/t_e420a5e12eb5
Rinat S (rsolmano)
requested review from
Olga Lavrichenko (OLavrik),
Rustam Sadykov (SBOne-Kenobi) and
danyaberezun
as code owners
August 30, 2026 15:35
Rinat S (rsolmano)
enabled auto-merge (squash)
August 30, 2026 16:59
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
danyaberezun
approved these changes
Sep 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix assistant-authored relative Markdown links so workspace evidence opens as a file tab in the active ThinkRail workbench instead of resolving against the browser origin and loading another SPA instance.
Changes
ChatTurnViewfile-open callbackhref; keep external URLs, protocol-relative URLs, fragments, rejected paths, and links without workspace context as safe new-tab anchorsMarkdownprimitive props-driven and preserve a stable renderer identity across workbench focus rerendersDeliberately excluded: no protocol-version enforcement, transport change, legacy layout RPC compatibility, or other layout behavior is included in this follow-up.
Testing
bun run e2e— 302 passed across 8 shardsbun run e2e -- e2e/tool-file-links.spec.ts— 2 passedbun run test— all 14 package tasks passed; server 845/845bun test apps/web/src/chat/assistantLinks.test.tsx apps/web/src/chat/tools/ToolFileLinks.test.ts— 7 passedbun run check:deps && bun run check:boundaries && bun run check:seams— all OKbun run lint— passed with six pre-existing unused-suppression warningsbun run typecheck— 14/14 tasks passedREADME.mdas a preview tab while external and rejected targets remained browser linksScreenshots
Before: relative assistant link is a browser anchor
Activating it opens another ThinkRail SPA at
/README.mdinstead of the file:After: workspace target is an in-app control
Activating it opens the existing workbench's
README.mdpreview tab: