Remove st.vvu.edu.gh from stoplist - official student domain of Valley View University - #40902
Open
John Sackey (hijacker-mills) wants to merge 1 commit into
Open
Conversation
…y View University Valley View University (vvu.edu.gh) is already approved in lib/domains/gh/edu/vvu.txt but its official student subdomain st.vvu.edu.gh was incorrectly in stoplist, causing isAcademic() to return false for xxx@st.vvu.edu.gh. Proof: - Official site: https://vvu.edu.gh/ - Student email page: https://vvu.edu.gh/student-email.php shows @st.vvu.edu.gh on Google Workspace - IT courses (4 years): https://vvu.edu.gh/course_details.php?id=4 BSc Information Technology and https://vvu.edu.gh/course_details.php?id=59 BSc Computer Science Overview: https://vvu.edu.gh/academic_programs_overview.php Fix: remove st.vvu.edu.gh from stoplist, vvu.edu.gh coverage then correctly includes st.vvu.edu.gh per README (subdomains included).
Collaborator
|
John Sackey (@hijacker-mills) lib/domains/stoplist.txt: this request has file path that is not expected in a pull request. This repository rules explain what kind of contributions are expected in pull requests. We'll review your request as soon as we can. If the issue concerns a domain that we do not accept due to abuse, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students). |
Philip Torchinsky (philipto)
added
the
problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valley View University (vvu.edu.gh) is already approved in lib/domains/gh/edu/vvu.txt but its official student subdomain st.vvu.edu.gh is incorrectly in stoplist, causing isAcademic() to return false for xxx@st.vvu.edu.gh.
Proof:
Fix: remove st.vvu.edu.gh from stoplist - vvu.edu.gh coverage then correctly includes st.vvu.edu.gh per README (subdomains included).