Prevent viewport scrolling on auto-wrap at the bottom row of alternate buffer - #336
Open
Fredy Wijaya (fredyw) wants to merge 2 commits into
Open
Prevent viewport scrolling on auto-wrap at the bottom row of alternate buffer#336Fredy Wijaya (fredyw) wants to merge 2 commits into
Fredy Wijaya (fredyw) wants to merge 2 commits into
Conversation
…e buffer When text auto-wraps at the bottom row of the alternate screen buffer, it previously triggered a scroll event that shifted the entire viewport up, which can cause full-screen TUI layouts, e.g. nvim/tmux to become misaligned. Since full-screen alternate buffer applications explicitly manage their layout and cursor positions and do not rely on terminal-managed auto-wrap scrolling, we disable scrolling on auto-wrap when the cursor is at the bottom row of the alternate buffer. Fixes JetBrains#335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When text auto-wraps at the bottom row of the alternate screen buffer, it previously triggered a scroll event that shifted the entire viewport up, which can cause full-screen TUI layouts, e.g.
nvim/tmuxto become misaligned.Since full-screen alternate buffer applications explicitly manage their layout and cursor positions and do not rely on terminal-managed auto-wrap scrolling, we disable scrolling on auto-wrap when the cursor is at the bottom row of the alternate buffer.
Before:
After:
Fixes #335