Open
Conversation
qradimir
approved these changes
Jul 6, 2023
Collaborator
qradimir
left a comment
qradimir
left a comment
There was a problem hiding this comment.
Looks good to me. I would like to see some tests for new functionallity
| @@ -0,0 +1,17 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Collaborator
There was a problem hiding this comment.
That's a redundant config file, consider to drop it.
| <component name="ProjectRootManager" version="2" languageLevel="JDK_11" default="true" project-jdk-name="11" project-jdk-type="JavaSDK"> | ||
| <output url="file://$PROJECT_DIR$/out" /> | ||
| </component> | ||
| <component name="ProjectType"> |
| import kotlin.io.path.Path | ||
| import kotlin.io.path.readText | ||
|
|
||
| class Iec61131Xml { |
Collaborator
There was a problem hiding this comment.
I think there is no major benefit of making all serializable classes nested inside a single class. Having them all top-level is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new project creation with functional blocks of a IEC 61131 project