Skip to content

Checks kind clears the changeset gate itself instead of asking a maintainer - #683

Merged
mikeallisonJS merged 1 commit into
mainfrom
checks-gate-self-service
Oct 15, 2026
Merged

mikeallisonJS merged 1 commit into
mainfrom
checks-gate-self-service

Conversation

@mikeallisonJS

Copy link
Copy Markdown
Collaborator

Summary

First live run with renovate/ admitted to the checks kind (#655). Phoebe took #640 and #641, both devDependency bumps opened before the renovate.json label rule landed, and stopped at a comment asking a maintainer for skip-changeset. The prompt had no step for a gate, and the releasing doc said a maintainer applies the label.

 checks-prompt.md, step 4 (Fix)
+  a gate red for want of a file or label is cleared by
+  writing the file or `gh pr edit --add-label`, per the repo's docs
 AGENTS.md, "Every PR carries a changeset"
+  no consumer-visible change → apply skip-changeset yourself
+  Renovate: runtime `dependencies` → patch changeset; anything else → label
 docs/releasing.md
-  A maintainer labels those skip-changeset
+  Anyone whose token can write labels does, Phoebe included
+  Renovate never relabels an open PR, so pre-rule bumps arrive unlabelled

The gate's own failure text in changeset.yml still says "a maintainer can label it". I left the workflow file alone; it can follow in a maintainer-pushed commit.

Evidence

  • Before: dogfood log, 2026-10-14
    [checks pr:641] I made no code change. The `changeset` check on PR #641 needs a maintainer to apply the `skip-changeset` label, so I left a PR comment asking for it.
    [checks pr:641] Checks fix for PR #641 produced no commits — leaving PR unchanged.
    
    After: vp test src/prompt.test.ts passes (23 tests); the dogfood tree is on this branch so the next checks unit on Update dependency vite-plus to v0.3.3 #640 or Update dependency @types/node to v24.19.2 #641 runs the new step live. Not yet observed at the time of opening.

Merge Danger

Door: two-way

Prose only. Revert the prompt line and the behaviour returns.

Blast Radius: consumers

prompts/checks-prompt.md ships in the package, so every consumer's checks agent gains the step. It acts only where the consumer's own docs name a file or label that satisfies a gate.

🤖 Generated with Claude Code

…tainer

On the first live run with Renovate admitted to the checks kind (#655), Phoebe
landed on two devDependency bumps that predate the renovate.json label rule,
read docs/releasing.md, and left a comment asking a maintainer to apply
skip-changeset. The doc said a maintainer does that; the prompt said nothing
about gates at all.

The prompt now names the case: a check that fails for want of a file or a
label is cleared by writing the file or applying the label, per the repo's
docs. AGENTS.md and the releasing doc give this repo's rule: runtime
dependency bump gets a patch changeset, anything else gets the label, and
Phoebe applies it. Renovate never relabels a PR already open, so the backlog
needs this path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: JesusFilm/phoebe/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 72cfaa7d-edbc-4aaa-b847-d96c96ea025f
📥 Commits

Reviewing files that changed from the base of the PR and between aabfbbd and 868ffc1.

📒 Files selected for processing: 4
  • .changeset/checks-gate-self-service.md
  • AGENTS.md
  • docs/releasing.md
  • prompts/checks-prompt.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:trusted Author is trusted by repo permissions or the VOUCHED list. label Oct 15, 2026
@mikeallisonJS
mikeallisonJS merged commit 0c6b656 into main Oct 15, 2026
6 checks passed
@mikeallisonJS
mikeallisonJS deleted the checks-gate-self-service branch October 15, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant