Repository navigation
Checks kind clears the changeset gate itself instead of asking a maintainer - #683
Merged
Merged
Conversation
…tainer On the first live run with Renovate admitted to the checks kind (#655), Phoebe landed on two devDependency bumps that predate the renovate.json label rule, read docs/releasing.md, and left a comment asking a maintainer to apply skip-changeset. The doc said a maintainer does that; the prompt said nothing about gates at all. The prompt now names the case: a check that fails for want of a file or a label is cleared by writing the file or applying the label, per the repo's docs. AGENTS.md and the releasing doc give this repo's rule: runtime dependency bump gets a patch changeset, anything else gets the label, and Phoebe applies it. Renovate never relabels a PR already open, so the backlog needs this path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First live run with
renovate/admitted to thecheckskind (#655). Phoebe took #640 and #641, both devDependency bumps opened before therenovate.jsonlabel rule landed, and stopped at a comment asking a maintainer forskip-changeset. The prompt had no step for a gate, and the releasing doc said a maintainer applies the label.The gate's own failure text in
changeset.ymlstill says "a maintainer can label it". I left the workflow file alone; it can follow in a maintainer-pushed commit.Evidence
vp test src/prompt.test.tspasses (23 tests); the dogfood tree is on this branch so the nextchecksunit on Update dependency vite-plus to v0.3.3 #640 or Update dependency @types/node to v24.19.2 #641 runs the new step live. Not yet observed at the time of opening.Merge Danger
Door: two-way
Prose only. Revert the prompt line and the behaviour returns.
Blast Radius: consumers
prompts/checks-prompt.mdships in the package, so every consumer's checks agent gains the step. It acts only where the consumer's own docs name a file or label that satisfies a gate.🤖 Generated with Claude Code