chore(webkit-rbe): pin @playwright/test 1.59.1 exact + make webkit smokes executor-dispatchable#434
Merged
Merged
Conversation
…okes executor-dispatchable Alignment PR for the GF WebKit cell (GloriousFlywheel #884): the cell bakes nixpkgs playwright-driver 1.59.1 / webkit-2272, and WebKit revisions are playwright-version-locked (unlike the CDP-stable chromium lane), so the consumer must match EXACTLY: - @playwright/test ^1.60.0 -> 1.59.1 (exact pin, no caret — the Skeleton/ Tailwind precedent; bumping playwright without a matching cell image breaks the remote webkit lane silently-until-proof) - the 2 webkit smoke targets + //:webkit_smoke_suite gain flywheel-eligible + gloriousflywheel-rbe-candidate tags: .bazelrc.flywheel's --test_tag_filters=flywheel-eligible would otherwise filter the suite to ZERO tests remotely (a vacuous green). Targets stay , so nothing dispatches them until an explicit //:webkit_smoke_suite proof run. Verified at 1.59.1/webkit-2272: just check; bazelisk test //:webkit_smoke_suite 2/2 (--nocache_test_results); H1+overflow e2e 20/20 under webkit-mobile AND chromium-mobile; bazel query 'tests(//:webkit_smoke_suite)' non-vacuous. Local note: a playwright version change requires 'pnpm exec playwright install' — stale per-revision binaries in the shared ~/Library/Caches/ms-playwright make project scheduling nondeterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer half of the GF WebKit executor lane (tinyland-inc/GloriousFlywheel#884, merged — the cell image now bakes playwright-driver 1.59.1 / webkit-2272).
@playwright/test:^1.60.0→1.59.1exact. WebKit revisions are playwright-version-locked (no nixpkgs rev ships 1.60's webkit-2287), so the consumer pins down to the cell. Exact, no caret — a silent minor bump would desync the remote lane. Chromium is unaffected (CDP is version-agnostic).flywheel-eligible+gloriousflywheel-rbe-candidatetags on the two webkit smoke targets and//:webkit_smoke_suite:.bazelrc.flywheelfilters remote tests toflywheel-eligible, so without these the remote suite filters to zero tests and passes vacuously. Targets remainmanual— nothing runs remotely until an explicit proof dispatch.Verified at 1.59.1:
just check·//:webkit_smoke_suite2/2 fresh · H1+overflow e2e 20/20 under webkit-mobile + chromium-mobile · suite query non-vacuous.Next (post-merge, GF side): new cell digest → chromium regression proof →
browser-rbe-proof.yml -f target=//:webkit_smoke_suite -f force_execution=true→ flipGF_REAPI_CELL_IMAGE_DIGEST→ promote the GF governance candidate to proved.