Conversation
Replace flat BUILT_IN_GLOBAL_TARGETS with a typed harness registry mapping harness names (claude, gemini, opencode, codex) to target paths. Add globalOverrides config field with closed-world key validation so each harness can receive tailored global rules on top of the shared global content. Key changes: - New harness registry in src/core/harness-registry.ts - globalOverrides field in Zod config schema with per-key validation - projects field is now optional (globals-only mode) - Per-harness content composition: shared global + override rules - Same-rule overlap detection within a harness (fails loudly) - Cross-harness rule reuse is allowed - Empty targets silently skipped (no auto-delete) - Unmatched override globs reported as warnings - Full backward compatibility with existing configs Closes #31 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-only mode
- Reject `globalOverrides: {}` in config validation, matching the existing
behavior for `global: []` and `projects: []`.
- Fix misleading 'No projects configured; nothing to do.' verbose message
when only global rules are synced (no projects configured).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…abels - Document globalOverrides in README with config example and field descriptions - Note that projects is optional (globals-only config is valid) - Optimize syncGlobal to pre-glob shared global paths once and pass resolved paths to detectOverlap instead of re-globbing per harness - Accept pre-computed GlobResult in loadRules to avoid redundant globbing - Extract pattern warning logic into collect-pattern-warnings module - Parse globalOverrides prefix in unmatched pattern warnings to assign distinct source labels (e.g. 'in globalOverrides.claude' not 'in global') - Fix test mock sequence to match optimized glob call order - Use resetAllMocks in beforeEach to prevent mock leakage between tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jercik
force-pushed
the
feat/per-harness-global-overrides
branch
from
4e29858 to
853c24d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Move sharedPaths variable inside the if(hasOverrides) block where it is actually consumed. Hoists sharedResult to function scope so both the global loading and override detection blocks can access it. This makes the coupling between global glob results and overlap detection explicit, preventing future misuse of a silently-empty sharedPaths array. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
1 participant
Summary
Replaces the flat
BUILT_IN_GLOBAL_TARGETSarray with a typed harness registry and adds aglobalOverridesconfig field for per-harness rule customization.Closes #31
Changes
New: Harness Registry (
src/core/harness-registry.ts)claude,gemini,opencode,codex) to their target pathsConfig Schema (
src/config/config.ts)globalOverridesfield:Record<HarnessName, string[]>with closed-world key validationprojectsoptional — configs with onlyglobaland/orglobalOverridesare valid (globals-only mode)global,globalOverrides, orprojectsis specifiedglobalOverrides: {}rejected at parse time (matching existingglobal: []andprojects: []behavior)hasPositiveGlobhelper extracted for DRY validationGlobal Sync (
src/core/sync-global.ts)globalrules + harness-specific override rulesglobalOverrides.<harness>:prefixloadRulesto avoid redundant filesystem traversalPattern Warning Parsing (
src/cli/collect-pattern-warnings.ts)globalOverrides.<harness>:prefixed patterns into distinct source labels"global"as canonical source in machine-readable output (--json,--porcelain); maps to"global config"only in human-readable stderrRun Sync Command (
src/cli/run-sync-command.ts)projectsarray (?? []fallback)collectGlobalPatternWarningsfor structured warning parsingDocumentation
globalOverridesconfig example, field documentation, and globals-only modeBackward Compatibility
Existing configs without
globalOverridescontinue to work identically. Machine-readable output (--json,--porcelain) preserves"global"as the warning source label. All original tests pass unchanged (with minor type-safety adjustments for the now-optionalprojectsfield).Tests
14 new tests covering: