Skip to content

Potential fix for 1 code quality finding #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slominskir merged 1 commit into from
Jun 15, 2026
Merged

Potential fix for 1 code quality finding #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/java/org/jlab/sim/presentation/controller/Directory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
public class Directory extends HttpServlet {

@Serial private static final long serialVersionUID = 1L;
private static final String LOOSE_PARAMETER = "loose";
private static final String LOOSE_TRUE_VALUE = "Y";

@EJB SoftwareService softwareService;
@EJB RepositoryService repositoryService;
Expand Down Expand Up @@ -120,14 +122,17 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
request.setAttribute("gapList", Arrays.asList(DocumentationGaps.values()));
request.setAttribute("esotericismList", Arrays.asList(Esotericism.values()));

final String YES = "Y";
if (YES.equals(request.getParameter("loose"))) {
if (isLooseModeRequested(request)) {
request.getRequestDispatcher("/WEB-INF/views/directory-loose.jsp").forward(request, response);
} else {
request.getRequestDispatcher("/WEB-INF/views/directory.jsp").forward(request, response);
}
}

private boolean isLooseModeRequested(HttpServletRequest request) {
return LOOSE_TRUE_VALUE.equals(request.getParameter(LOOSE_PARAMETER));
}

private String createSelectionMessage(
Paginator paginator,
String softwareName,
Expand Down
Loading