chore: require JSS >= 0.0.211 so serving never seeds index.html/.acl#6
Merged
Conversation
JSS used to seed a landing page and .acl files into the server root on first start, polluting whatever directory servejss was pointed at. Upstream fixed this in 0.0.211 (ec8547b, #578/#579): seeding is skipped in --public and --read-only modes. Raise the dependency floor so every install is guaranteed the guard, refresh the lockfile (resolves 0.0.212), and bump to 0.0.8. README notes the global-jss fallback: a stale global install also needs updating, since bin/jsserve.js falls back to it when the bundled dependency is missing.
There was a problem hiding this comment.
Pull request overview
This PR raises the minimum required javascript-solid-server (JSS) version so servejss no longer risks JSS seeding index.html and .acl files into the served directory on startup, and updates docs/versioning to match.
Changes:
- Bump
javascript-solid-serverdependency floor to>=0.0.211and refresh the lockfile (resolving0.0.212). - Bump
servejsspackage version to0.0.8. - Document the requirement and the “fallback to globally installed
jss” behavior in the README.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents the JSS minimum version and notes updating any globally installed jss fallback. |
| package.json | Bumps servejss version and raises the javascript-solid-server minimum version. |
| package-lock.json | Refreshes lockfile to reflect the new JSS floor and updated dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Older JSS versions seed a landing page (
/index.html) and.aclfiles into the server root on first start — which for servejss means polluting whatever directory it was pointed at.Fix
Upstream JSS fixed this in 0.0.211 (
ec8547b, #578/#579): root seeding is skipped entirely in--publicand--read-onlymodes, with servejss's serve-a-directory use case named as the motivation.javascript-solid-serverfloor raised>=0.0.136→>=0.0.211, so every install is guaranteed the guardjssalso needs updating, sincebin/jsserve.jsfalls back to it when the bundled dependency is missing — a lockfile bump alone can't fix that pathVerified
Ran
servejssagainst a directory containing a single file, exercised GET (200) and PUT (201), then inspected the directory: only the original file and the PUT-created one present — noindex.html, no.aclseeded.