Delegate jspod install to upstream jss install; bump jss to ^0.0.207#78
Merged
Conversation
0.0.205-207 are fixes only: IdP hardening (incl. #558 passkey degradation on stale WebViews — upstream half of jspod#65), RFC 9207 'iss' conformance, tunnel credential passthrough, conneg/git HEAD parity. Validated on a throwaway pod: jss install chrome → 1/1 installed, app serves HTTP 200.
Replace the wrapper-side install plumbing (runInstall git clone + dual-push, parseAppSpec, loadBundle/resolveBundleSource, printInstallHelp — 255 lines) with a 37-line spawn of 'jss install', which has shipped the same plumbing since JSS 0.0.198 (JSS#464). jspod keeps its two policies on top: - --pod defaults to jspod's port 5444 (jss alone defaults to 4443) - bare 'jspod install' resolves to '--bundle default' Validated against a throwaway pod on jss 0.0.207: - named install (vellum) → 1/1, app serves HTTP 200 - bare install → 'Installing 12 apps from bundle Default', 10/12 ok - the 2 failures (git, chat: HTTP 413 on push) reproduce identically with the OLD implementation — pre-existing jss-side body limit on large packs, not a regression - --help passes through to jss install --help (source of truth) Behavior deltas: jss-styled output/help instead of chalk boxes; repeated --bundle is now last-wins; --nostr-privkey (NIP-98) gained. Fixes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
Two commits, validated together on a throwaway pod (port 5777, isolated root — live pod untouched):
1.
chore: bump javascript-solid-server to ^0.0.2070.0.205–207 are fixes only: IdP hardening (incl. #558 — passkey degradation on stale WebViews, the upstream half of jspod#65), RFC 9207
issconformance, tunnel credential passthrough, conneg/git HEAD parity.2.
refactor: delegate jspod install to upstream jss install-255 +37inindex.js. The plumbing (spec parsing, bundles, IdP auth, git dual-push) has lived upstream since JSS 0.0.198 (JSS#464) and was byte-for-byte duplicated here.jspod installstays as a command; it now spawnsjss installwith jspod's two policies applied:--poddefaults tohttp://localhost:5444(jss alone: 4443)jspod install→--bundle default(skipping value-flags, sojspod install --user bobstill counts as bare)The first-run bootstrap in
lib/start.jspasses--bundle default --pod <url>explicitly and flows through unchanged.Validation (jss 0.0.207)
jss install chromejspod install vellumjspod install --helpjss install --helpgit,chat— HTTP 413 on push)Behavior deltas (accepted per #48: "jss install --help is the source of truth")
TOKEN_SECRETpath, oidc Node-version warning)--bundle a --bundle bis now last-wins (was: both)--nostr-privkeyNIP-98 install authDeliberately not touched: jspod's own version and CHANGELOG (avoids conflict with #76; both ride in the next release cut).