Repository navigation
9.47.1 - #757
Merged
Merged
9.47.1#757
Conversation
One PostgreSQL fix, #750 / #751 contributed by @marc-RocketRez: the index introspection query identified rows by regclassout's rendering of the table, and none of the four spellings it compared against quoted the schema. Any schema that has to be quoted -- a reserved word such as order or user, or one carrying uppercase -- read back no indexes at all, so every declared index was Missing, the patch was a bare create index, and the second run answered 42P07 and aborted the rest of the migration. The primary key constraint's name rides the same rows and was not read back either; with a custom PK name that compared against the derived default and emitted a rename off a constraint that was never there. Nothing public added, removed or changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release. One PostgreSQL fix, already on master, plus its release notes.
What is in it
regclassout's rendering of it and matched that against four spellings, none of which quoted the schema. Any schema that has to be quoted read back no indexes at all, so every declared index wasMissing, the patch was a barecreate index, and the second run answered42P07and aborted everything behind it.Why a patch
No working deployment changes behaviour. For a schema that needs no quoting,
relnameandregclassout's rendering name the same table and the comparison lands where it always did. In a schema that does need quoting, Weasel was unusable past the first run, so there is no old behaviour to preserve. Nothing public was added, removed or changed.Release notes
Appended as a
## 9.47.1section todocs/release-9-47.md, following 9.46.1's shape. Theregclassouttable in it is measured on PostgreSQL 15.3 rather than reasoned:public, insearch_pathdocsreporting, not insearch_pathreporting.docsorder"order".docsMySchema"MySchema".docsThe page builds locally with
npm run docs-build.🤖 Generated with Claude Code