Conversation
Author
|
Opened against the wrong repo by mistake, moved to ethereum#168 |
Author
|
sorry Jason, my claude is going crazy 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
datais currently the UTF-8 bytes of the builder URL exactly as advertised, so a trailing/, an explicit:443or different casing in the proposer's configuration produces different signed bytes and fails the builder's check with a 400. This already happened on devnet-8 with a URL that only differed by a trailing slash, see the discussion on the Eth R&D Discord (#interop) and JasonVranek/epbs-config-flow#1 (comment).This defines the default as the builder's hostname instead, lowercased ASCII with IPv6 literals in RFC 5952 form, dropping scheme, userinfo, port, path, query and fragment. It is a pure function of the configured URL string, so validator clients in mixed DV clusters derive identical bytes without a URL parser that implements WHATWG semantics, and it is applied when constructing the
BuilderRequestAuthonly, the signed bytes are still verified unchanged which addresses the concern that got the previous canonicalization removed.Default auth datasection to the validator spec with the derivation, a reference function and test vectorsBuilderRequestAuth.datadescriptiondatawith proposers out of bandOpened against the ethereum#165 branch as the auth data only exists there, keymanager-APIs ethereum#88 and beacon-APIs #630 restate the old default and will be updated to reference this section.