Fix tooltips clashing with open menus - #3725
Open
ewanhowell5195 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a menu from a toolbar button leaves that button's tooltip on screen, rendering behind the menu. Tooltips of other tools also render behind menus and config dialogs, so they get cut off instead of sitting on top.
Tooltips were on a lower z-index than menus and config dialogs, and nothing hid the tooltip of the tool a menu was opened from.
Tooltips now sit above both, and the tool a menu or config dialog is anchored to hides its own tooltip while it is open.
Toolbar menus were positioning themselves from hand written coordinates rather than passing their button, so they had no anchor to hide. They now pass the button like every other menu does.
Fixes #3468