🎨 Palette: Improve accessibility of form controls#23
Conversation
- Added `role="group"` and `aria-label` to the wind speed unit toggle in the hardware configuration form. - Added `aria-pressed`, `focus-visible` outline rings, and transition styles to the toggle buttons. - Added `aria-label` to the JSON backup file input in data portability settings. - Documented the custom toggle group pattern in `.Jules/palette.md`. Co-authored-by: Jandave0 <185737041+Jandave0@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What:
role="group",aria-label,aria-pressed,focus-visibleoutlines) to the wind speed unit toggle in the Hardware Configuration settings.aria-labelto the backup file<Input>in the Data Portability settings..Jules/palette.md.Why:
Custom toggle button groups and file inputs without explicit labeling or keyboard navigation support are inaccessible. Screen reader users need proper context to understand active states, and keyboard users need visible focus indicators to navigate confidently.
Accessibility:
focus-visiblestyling that matches the app's design system tokens (accent-primary).PR created automatically by Jules for task 16177850828270078904 started by @Jandave0