🎨 Palette: Improve accessibility of wind speed unit toggle#22
Conversation
Co-authored-by: Jandave0 <185737041+Jandave0@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Improved the accessibility of the wind speed unit toggle (m/s vs km/h) by adding ARIA attributes and visible focus states.
🎯 Why: Custom segmented controls often lack essential accessibility features, making them difficult or impossible for screen reader and keyboard users to operate.
📸 Before/After: Keyboard users can now tab to the toggle and see a visible focus ring (
focus-visible:ring-2 focus-visible:ring-accent-primary). Hover styling was also added.♿ Accessibility: Added
role="group"andaria-labelto the container. Addedrole="switch"andaria-checkedto the buttons. Added descriptivearia-labels to each button. Addedfocus-visiblestyling for keyboard navigation.Additionally, updated the Palette journal (
.Jules/palette.md) with this finding for future reference.PR created automatically by Jules for task 17558608810956056805 started by @Jandave0