🎨 Palette: Enhance wind speed unit toggle accessibility#19
Conversation
Co-authored-by: Jandave0 <185737041+Jandave0@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Improved the wind speed unit toggle group by adding
role="group",aria-label,aria-pressedstates, hover transition colors, and explicit focus-visible states. Also added a learning to.Jules/palette.md.🎯 Why: Custom inline toggle groups (like unit switchers) need explicit ARIA roles and active state indications to be properly understood by screen readers, which is easily overlooked when not using standard form components. The visual polish improves mouse and keyboard navigation visibility.
📸 Before/After: Before, it was a regular
divand the selected button just had a background color. Now, it has focus rings and screen readers can understand the current selected state.♿ Accessibility: Added
role="group",aria-label="Wind speed unit",aria-pressed, andfocus-visible:ring-2 focus-visible:ring-border-defaultfor screen readers and keyboard navigation.PR created automatically by Jules for task 11005600071662813348 started by @Jandave0