fix: preserve diff scroll position during auto-refresh#24
Merged
Conversation
2s poll tick was resetting viewport to top via unconditional GotoTop() in handleDiffLoaded. Add resetScroll flag to diffLoadedMsg — only true for user-initiated loads (file switch, split toggle, resize). Tick refreshes pass false. Also skip viewport update entirely when content unchanged (lastDiffContent dedup). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
viewport.New() creates empty viewport, but dedup check in handleDiffLoaded skipped SetContent when diff unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Locks behavior: handleResize clears lastDiffContent so handleDiffLoaded re-applies content to recreated viewport. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pollIntervaltick was callingviewport.GotoTop()unconditionally on every diff reload, resetting scroll positionresetScrollflag todiffLoadedMsg— onlytruefor user-initiated loads (file switch, split toggle, resize)lastDiffContentdedup to skip viewport update entirely when content unchanged (prevents flicker)Test plan
go run .in repo with long diff, scroll down, wait >2s — scroll preservedn/p— scroll resets to topv— scroll resets to topmake testpasses🤖 Generated with Claude Code