Skip to content

Pass settings to MapperDelaunay in factory#207

Merged
Jammy2211 merged 2 commits intofeature/linalg_mixed_precisionfrom
copilot/sub-pr-205-again
Feb 8, 2026
Merged

Pass settings to MapperDelaunay in factory#207
Jammy2211 merged 2 commits intofeature/linalg_mixed_precisionfrom
copilot/sub-pr-205-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 8, 2026

The mapper factory was not propagating settings to MapperDelaunay, causing caller-provided inversion settings (including use_mixed_precision) to be ignored for Delaunay meshes while working correctly for Rectangular and RectangularUniform meshes.

Changes

  • Added settings=settings parameter to MapperDelaunay constructor call in mapper_from() factory function
elif isinstance(mapper_grids.source_plane_mesh_grid, Mesh2DDelaunay):
    return MapperDelaunay(
        mapper_grids=mapper_grids,
        border_relocator=border_relocator,
        regularization=regularization,
        settings=settings,  # Now propagates settings
        preloads=preloads,
        xp=xp,
    )

All three mapper types now consistently receive settings from the factory.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Jammy2211 <23455639+Jammy2211@users.noreply.github.com>
Copilot AI changed the title [WIP] Update linalg mixed precision implementation based on feedback Pass settings to MapperDelaunay in factory Feb 8, 2026
Copilot AI requested a review from Jammy2211 February 8, 2026 09:27
@Jammy2211 Jammy2211 marked this pull request as ready for review February 8, 2026 09:30
@Jammy2211 Jammy2211 merged commit 6b20761 into feature/linalg_mixed_precision Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants