Skip to content

Derive mixed precision from settings object to prevent propagation bugs #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 2 commits into from
Feb 8, 2026
Merged

Derive mixed precision from settings object to prevent propagation bugs #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50e5e6
Initial plan
Copilot Feb 8, 2026
29b8118
Remove redundant use_mixed_precision parameter, derive from settings
Copilot Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion autoarray/inversion/inversion/imaging/mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ def curvature_matrix(self):
settings=self.settings,
add_to_curvature_diag=True,
no_regularization_index_list=self.no_regularization_index_list,
use_mixed_precision=self.settings.use_mixed_precision,
xp=self._xp,
)

Expand Down
2 changes: 2 additions & 0 deletions autoarray/inversion/inversion/interferometer/mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,14 @@ def curvature_matrix(self) -> np.ndarray:
real_curvature_matrix = inversion_util.curvature_matrix_via_mapping_matrix_from(
mapping_matrix=self.operated_mapping_matrix.real,
noise_map=self.noise_map.real,
settings=self.settings,
xp=self._xp,
)

imag_curvature_matrix = inversion_util.curvature_matrix_via_mapping_matrix_from(
mapping_matrix=self.operated_mapping_matrix.imag,
noise_map=self.noise_map.imag,
settings=self.settings,
xp=self._xp,
)

Expand Down
3 changes: 1 addition & 2 deletions autoarray/inversion/inversion/inversion_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ def curvature_matrix_via_mapping_matrix_from(
add_to_curvature_diag: bool = False,
no_regularization_index_list: Optional[List] = None,
settings: "SettingsInversion" = SettingsInversion(),
use_mixed_precision: bool = False,
xp=np,
) -> np.ndarray:
"""
Expand All @@ -105,7 +104,7 @@ def curvature_matrix_via_mapping_matrix_from(
else:
# Choose compute dtype

compute_dtype = xp.float32 if use_mixed_precision else xp.float64
compute_dtype = xp.float32 if settings.use_mixed_precision else xp.float64
out_dtype = xp.float64 # always return float64 for downstream stability

A = mapping_matrix
Expand Down