Skip to content

feat: add gem deletion with confirmation dialog - #98

Merged
JakesMD merged 4 commits into
developfrom
feature/76-delete-gem
Jul 2, 2026
Merged

feat: add gem deletion with confirmation dialog#98
JakesMD merged 4 commits into
developfrom
feature/76-delete-gem

Conversation

@JakesMD

@JakesMD JakesMD commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds delete gem feature with confirmation dialog from the collection view app bar menu
  • Fixes RangeError when gems list becomes empty after deletion (navigates back to home)
  • Adds E2E tests for the full delete gem flow

Test plan

  • Open recents collection with at least one gem → tap 3-dot menu → Edit and Delete options appear
  • Tap Delete → confirmation dialog appears
  • Confirm deletion → deleteGem called with correct gem ID
  • Delete last gem → navigates back to home page
  • Delete one of two gems → stays on collection page showing remaining gem

@JakesMD
JakesMD merged commit 1a69d20 into develop Jul 2, 2026
1 check passed
@JakesMD
JakesMD deleted the feature/76-delete-gem branch July 2, 2026 06:57
JakesMD added a commit that referenced this pull request Jul 2, 2026
* Add sync wiki job (#90)

* Auto-open release PR (#92)

* Add wiki pages (#96)

* Add github flow

* Switch to hobnob

* Add supabase schemas

* Add wiki pages

* Add E2E test infrastructure

* Update dependencies

* fix: allow deleting any gem line, not just last (#97)

* fix: allow deleting any gem line, not just last

* fix: start local Supabase db before running db:test

* feat: add gem deletion with confirmation dialog (#98)

---------

Co-authored-by: Jakes <71591438+JakesMD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant