Fix missing avatars key crashing shared gem fetch - #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_gem_with_peoplebuilt each person's JSON from the rawpeoplerow, omitting theavatarskey the Dart client model requires (CPeopleTable.avatarsis a requiredPgJoinToMany), causing "The key 'avatars' was not found in the JSON data." when viewing a shared gem that has a person assigned to a line.avatars: nullto each person object, mirroring the existinggem_share_tokensfix on the gem object.avatarskey presence.Test plan
hobnob db:test— all pgTAP tests pass (19/19)flutter run -d chrome: seeded a gem/line/person/share-token in local Postgres, loaded/#/shared-gem?token=..., confirmed the page renders with no error andCPerson.avatarsis[]