Fix appinfo/info.xml schema + add John McLear as author#94
Merged
Conversation
The new lint-info-xml CI workflow (e5e1a87) immediately caught real schema violations in our manifest that would have blocked app-store submission. Fix them now while the issues are small: - Add a required <category>office</category> element. The schema declares category as minOccurs=1; without it the manifest fails validation regardless of all the other content. - Re-order elements to match the strict <xs:sequence> the schema declares. The <dependencies>, <repair-steps>, and <settings> blocks were in the wrong positions relative to the schema's fixed order. - Re-order <admin> before <admin-section> inside <settings> for the same reason. - Declare the supported PHP range (<php min-version='8.1' max-version='8.5'/>) inside <dependencies>. We were silent on PHP previously; 8.5 is the current upstream upper bound (matches the Notes app). - Bump NC <min-version> from 30 to 31. NC30 is EOL and PHP 8.1 drops with NC31, so this lets the CI matrix stay at 8.2+ without drifting from the declared compat. - Drop the deprecated empty <types><filesystem/></types> wrapper that newer NC apps don't use. - Add <website>, <bugs>, <repository> pointing at the GitHub repo so the app-store listing has the right outbound links. - Add John McLear as second <author>. Verified locally: - xmllint --schema info.xsd appinfo/info.xml --noout → validates - composer test:phpunit → 395/395 (no behaviour change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real test of the CI workflows that landed in e5e1a87. The new
lint-info-xmljob immediately surfaced real schema violations in our manifest that would have blocked app-store submission.What changed
<category>office</category>. Required by the schema (minOccurs=1); without itxmllintfails regardless of all the other content.<xs:sequence>frominfo.xsd:category, website, bugs, repository, dependencies, repair-steps, settings.<admin>before<admin-section>inside<settings>for the same reason.<php min-version="8.1" max-version="8.5"/>) inside<dependencies>. We were silent on PHP previously.min-versionfrom 30 to 31 so the CI matrix doesn't have to test PHP 8.1. NC30 is EOL and dropping it lets the matrix stay at 8.2+ without drifting from the declared compat. Saves CI minutes and avoids testing a version we'd otherwise barely use.<types><filesystem/></types>wrapper that newer NC apps don't use.<website>,<bugs>,<repository>pointing at the GitHub repo so the app-store listing has the right outbound links.<author>.Verified
xmllint --schema info.xsd appinfo/info.xml --noout→ validatescomposer test:phpunit→ 395/395 (no behaviour change)This PR is also the first one that will actually trigger the new CI workflows on GitHub's runners — so we'll get live feedback on whether the YAMLs themselves work end-to-end.