Conversation
- Renamed fle/commons/models/achievements.py -> production_flows.py - Renamed fle/env/utils/achievements.py -> achievement_calculator.py - Deleted fle/env/utils/profits.py (legacy code) - Updated all imports to use new module paths - Replaced get_achievements() calls with AchievementTracker.calculate_achievements() - Fixed gym environment to use proper ProductionFlows objects instead of dicts - Updated all evaluators and task verification to use new achievement system - Deleted tests/eval/test_profits.py (testing removed functionality)
- Remove broken is_valid() method that always returned true - Fix None handling in ProductionFlows.from_dict() for Lua nil values - Add graceful error handling for malformed crafted data - Add comprehensive test suite covering edge cases and validation - Tests reveal and fix real bugs in the implementation
…essary error handling added by claude
- Changed Response object to contain absolute flows instead of delta flows - Updated get_observation to use Response flows when available for consistency - Added explicit delta_flows to info dict for cases where step changes are needed - Now both Response and Observation contain the same canonical absolute flow data
Collaborator
Author
|
#308 addresses the same task so noting this for future review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #278
work I did to try to sort out achievements and delete profits