Skip to content

An accurate renderer of the Factorio gamestate#280

Open
JackHopkins wants to merge 28 commits intomainfrom
sprites/active_inactive
Open

An accurate renderer of the Factorio gamestate#280
JackHopkins wants to merge 28 commits intomainfrom
sprites/active_inactive

Conversation

@JackHopkins
Copy link
Copy Markdown
Owner

  • Add a renderer.
  • Add CLI entrypoints to:
    • Download the spritesheets from HuggingFace
    • Convert them into sprites

@JackHopkins JackHopkins requested a review from kantneel July 23, 2025 12:47
Copy link
Copy Markdown
Collaborator

@kiankyars kiankyars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and do not understand why this is being added to the FLE repo, I believe we make a separate repo for this called factorioio-renderer as the only coupling point b/w the two that I found is factorio instance, which can be simply imported from fle as an external library.

@kiankyars kiankyars force-pushed the sprites/active_inactive branch from e37318c to c365ce6 Compare August 1, 2025 15:11
@JackHopkins
Copy link
Copy Markdown
Owner Author

This is a reasonable idea. The main argument I can think of to keep it in-repo, is that Gym environments support a render call to generate a frame of the environment: https://gymnasium.farama.org/api/env/#gymnasium.Env.render

i.e 'render' is a part of the environment Env itself. @kantneel what do you think?

@kantneel
Copy link
Copy Markdown
Collaborator

kantneel commented Aug 5, 2025

Yeah I agree this should be exposed through the render() method for the gym env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants