fix(get_entities): bugs lab is not shown after researching steal-processing#150
Open
ryukez wants to merge 2 commits intoJackHopkins:mainfrom
Open
fix(get_entities): bugs lab is not shown after researching steal-processing#150ryukez wants to merge 2 commits intoJackHopkins:mainfrom
ryukez wants to merge 2 commits intoJackHopkins:mainfrom
Conversation
Owner
|
Oh interesting! Thanks for looking into this. We can't comment out those lines because we need the Lab entity to contain the research that it is currently working on. I will see if we can fix the root cause. |
7704deb to
b900035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug that lab is not shown after researching steal-processing or logstic science pack 🤔 (In Open-Play)
before researching steal-processing
after

I noticed this happens after researching steal-processing, logistic science pack, or solar energy. Though I'm not sure about the precise trigger, it seems to happen in technologies around logistic science pack.
And finally it turned out that it is caused by lines in serialize.lua around lab serialization, and it is resolved by commenting them out.
I'm sorry but I'm not familiar with factorio API and Lua code, so it was hard to find the root cause...
For now, this code is used to add
researchattribute to lab entity and it would be OK to comment it out, because research progress can be obtained by get_research_progress tool and it's something shared among all labs.