Repository navigation
Credit the published sources: Newman et al. (1990), Williams & Newman (1982), Dukes et al. (1995), and the 1988 worked example (#105, #106, #109) - #126
Merged
Conversation
…88 worked example (#105, #106, #109) #105. The model of fit_solomon_glm() is the pseudo-analysis of covariance of Newman, Benz, and Williams (1990, equation 7, p. 98), reparameterized. The methods guide now lists it as a published Solomon proposal with contemporary inference and names solomonR's additions; ?fit_solomon_glm, the GLM vignette, the worked example, and the README give its source and the authors' caution about the zero coding (p. 98). report_solomon() and analysis_plan_solomon() cite it with Lin (2013) where they describe the pretest adjustment (GLM, N-group, MI, tipping-point, and MMRM paths), and the registry lists it for fit_solomon_glm(), so the citing article's table shows it. A known-result test reproduces their worked example (slope .55264, SSW 62.39, F = 21.01; interaction F = 0.21 from the data, printed .22; adjusted means 12.45 and 7.55) and the 2 x 2 analysis (Table 2). Williams and Newman (1982), a six-group single model without person vectors, is added to the history article as a published answer to Campbell and Stanley's "no single procedure" remark; the history article also gains a 1990 section with the reproduction, and its timeline labels no longer overlap. #106. Dukes, Ullman, and Stein (1995) is cited as a published precedent for the latent-variable analysis in the SEM article (new section: three two-group models, loadings tested and intercepts imposed, no interaction test, classroom means), the methods guide, the coverage article, and the references. No SEM code changes. #109. New data set waltonbraver1988 (Table 3, p. 153) with data-raw code, a help page of known results, and a known-result test of the published Tests A, D, E, H, and I, the pretest main effect, the 1988 path, and the power remark. A second test reproduces Tests E and H of Sawilowsky and Markman's counterexample, read in its 1988 ERIC version (ED316556), and shows that its printed error entry 1200.04 is a misprint. The classic vignette gains a section on both worked examples. ROADMAP no longer calls the historical workflow validated: the computations reproduce, the Monte Carlo rates only in part. All new works are in references.Rmd, the coverage article (rows and references), and each article that cites them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
?waltonbraver1988: the footnote on p. 153 is now paraphrased in full (conditional on reaching the step and on the null hypothesis there, offered because the experiment-wise rate is hard to specify in advance); the history article's version is corrected the same way. The power remark now gives the printed "p > .07" and the exact .076 separately. #105: the GLM vignette no longer reads as if the package avoids the zero coding Newman et al. (1990) cautioned against; like the help page, it says the four contrasts do not depend on it and the `pretested` coefficient does. ?fit_solomon_glm and the methods guide print their interaction restriction, b1 = b3 + b2 - b4 (p. 98). The help page, coverage row, and NEWS claim only what the known-result test reproduces (slope, SSW, and the treatment and interaction F, printed .22); the test now also checks that equation 7 has the package's fitted values, that the restricted models give the printed SS7, SS9, SS10, and SS11, that the interaction and treatment restrictions equal the squared t of the matching contrasts, and the pretesting row (F = .36). fit_solomon_glm() is no longer registered with newman1990: its report cites Newman et al. only with a pretest, so the citing table no longer lists it as core, and a test guards that contract. "How to Cite solomonR" explains when Newman et al. (1990) is cited and adds Williams and Newman (1982), with references. History: Solomon (1949, p. 146) is paraphrased rather than closely echoed. Coverage: the Williams and Newman row cites pp. 83-89 with Table 4; Sawilowsky and Markman's Test I computation is marked as a reconstruction from their z values here, in references.Rmd, the classic vignette, and the test comment. #106: the SEM article names what solomonR shares with Dukes et al. (1995) (multiple-group mean structure, loadings tested before latent means, indicator means held equal, and the equal pretest-to-posttest path that is the latent ANCOVA's common slope), and the SEM article, coverage, and references list all four planned elements under #117. ROADMAP credits #51 to PR #76 and leaves #109's PR number to be added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
NEWS: this branch's sections go under the development heading, above the 0.8.1 section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pretest is now centered at the pretested participants' mean (#104), so the attribution text of this branch is updated: ?fit_solomon_glm, the methods guide, the GLM vignette, and NEWS say that the pretested coefficient compares the groups at that mean, where Newman et al. (1990, p. 101) took their adjusted means, and that their caution about a pretest of 0 applies to the uncentered coding of the paper. The methods guide's section on the model, moved by this branch to the published proposals, gains master's pretest effects; the old extension section is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vignettes/articles/sem.Rmd: master's section on reporting latent models comes first, after the invariance example it refers to, then this branch's section on Dukes et al. (1995). NEWS and WORDLIST keep both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NEWS: this branch's sections go first under the development heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NEWS: this branch's sections go first under the development heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105, #106, and #109. The sources were read in full, and a second reader checked every page, quotation, and number against the PDFs before implementation. An independent reviewer then checked the branch, and all 12 of its findings were fixed or resolved.
#105: the published origin of the unified model
test-glm-newman1990.Rpins these values.?fit_solomon_glm, the GLM vignette, the worked example, and the README now call it a published Solomon proposal with contemporary inference.marginal_solomon(), covariates, several-treatment designs, and permutation and equivalence tests.report_solomon()cites Newman et al. (1990) alongside Lin (2013) wherever the pretest adjustment is used. The key is not in the core registry, because it is cited only when a pretest is used.report_solomon(), because its six-group model is not whatfit_solomon_glm()fits; the decision is recorded on [v1.0] Credit the published origin of the unified model (Newman, Benz, & Williams, 1990; Williams & Newman, 1982) #105.#106: Dukes, Ullman, and Stein (1995)
#109: the Walton Braver and Braver (1988) worked example
waltonbraver1988holds Table 3 (p. 153), with data-raw code, a help page of known results with a page for every caveat, and COPYRIGHTS and pkgdown entries.Checks
tools/check-references.R: 553 entries match 102 canonical references.References
Dukes, R. L., Ullman, J. B., & Stein, J. A. (1995). An evaluation of D.A.R.E. (Drug Abuse Resistance Education), using a Solomon four-group design with latent variables. Evaluation Review, 19(4), 409–435. https://doi.org/10.1177/0193841X9501900404
Walton Braver, M. C., & Braver, S. L. (1988). Statistical treatment of the Solomon four-group design: A meta-analytic approach. Psychological Bulletin, 104(1), 150–154. https://doi.org/10.1037/0033-2909.104.1.150
The full references for Newman et al. (1990), Williams and Newman (1982), and Sawilowsky and Markman (1988) are in vignettes/articles/references.Rmd on this branch.
🤖 Generated with Claude Code