Skip to content

Credit the published sources: Newman et al. (1990), Williams & Newman (1982), Dukes et al. (1995), and the 1988 worked example (#105, #106, #109) - #126

Merged
JUhalt merged 8 commits into
masterfrom
docs/105-attribution
Oct 8, 2026
Merged

JUhalt merged 8 commits into
masterfrom
docs/105-attribution

Conversation

@JUhalt

@JUhalt JUhalt commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Fixes #105, #106, and #109. The sources were read in full, and a second reader checked every page, quotation, and number against the PDFs before implementation. An independent reviewer then checked the branch, and all 12 of its findings were fixed or resolved.

#105: the published origin of the unified model

  • The model is published. It is Newman, Benz, and Williams's (1990, p. 98) model, which they call a "psuedo-analysis [sic] of covariance". solomonR's coding has the same column space as their equation 7. Their worked example reproduces: slope .55264, within-groups SS 62.39, F = 21.01, and F = 0.21 for the interaction, against the printed .22. test-glm-newman1990.R pins these values.
  • Labels changed.
    • The methods guide, ?fit_solomon_glm, the GLM vignette, the worked example, and the README now call it a published Solomon proposal with contemporary inference.
    • They give the restriction as printed (p. 98) and the authors' caution about zero coding.
    • They list solomonR's additions: named contrasts with intervals, HC3 and CR2, Satterthwaite df, GLM families, offsets, marginal_solomon(), covariates, several-treatment designs, and permutation and equivalence tests.
  • Reports. report_solomon() cites Newman et al. (1990) alongside Lin (2013) wherever the pretest adjustment is used. The key is not in the core registry, because it is cited only when a pretest is used.
  • History. Williams and Newman (1982) fit the whole design in one six-group model, a published answer to Campbell and Stanley's "no single procedure" (p. 25). The history article now has 1982 and 1990 sections, with a timeline that does not overlap. The citing article and the coverage article include both works. Williams and Newman (1982) is not cited by report_solomon(), because its six-group model is not what fit_solomon_glm() fits; the decision is recorded on [v1.0] Credit the published origin of the unified model (Newman, Benz, & Williams, 1990; Williams & Newman, 1982) #105.

#106: Dukes, Ullman, and Stein (1995)

#109: the Walton Braver and Braver (1988) worked example

  • New data set. waltonbraver1988 holds Table 3 (p. 153), with data-raw code, a help page of known results with a page for every caveat, and COPYRIGHTS and pkgdown entries.
  • Tests. Its test reproduces Tests A, D, E, H, and I, the pretest main effect, the 1988 decision path, and the power remark. It also checks the Sawilowsky and Markman counterexample (1988 ERIC version):
    • Tests E and H reproduce, and the printed 1200.04 is a misprint (the error SS is 1148.14);
    • their Test I is reconstructed from their z values.
  • Vignette. classic-solomon.Rmd gains a "Published worked examples" section. The pre-registered validation article is unchanged.
  • Roadmap. The validation item now says what is reproduced.

Checks

  • Full test suite: 2,885 expectations, 0 failures.
  • tools/check-references.R: 553 entries match 102 canonical references.
  • The spelling check is clean, and all 8 changed articles render.

References

Dukes, R. L., Ullman, J. B., & Stein, J. A. (1995). An evaluation of D.A.R.E. (Drug Abuse Resistance Education), using a Solomon four-group design with latent variables. Evaluation Review, 19(4), 409–435. https://doi.org/10.1177/0193841X9501900404

Walton Braver, M. C., & Braver, S. L. (1988). Statistical treatment of the Solomon four-group design: A meta-analytic approach. Psychological Bulletin, 104(1), 150–154. https://doi.org/10.1037/0033-2909.104.1.150

The full references for Newman et al. (1990), Williams and Newman (1982), and Sawilowsky and Markman (1988) are in vignettes/articles/references.Rmd on this branch.

🤖 Generated with Claude Code

JUhalt and others added 2 commits October 4, 2026 01:13
…88 worked example (#105, #106, #109)

#105. The model of fit_solomon_glm() is the pseudo-analysis of covariance
of Newman, Benz, and Williams (1990, equation 7, p. 98), reparameterized.
The methods guide now lists it as a published Solomon proposal with
contemporary inference and names solomonR's additions; ?fit_solomon_glm,
the GLM vignette, the worked example, and the README give its source and
the authors' caution about the zero coding (p. 98). report_solomon() and
analysis_plan_solomon() cite it with Lin (2013) where they describe the
pretest adjustment (GLM, N-group, MI, tipping-point, and MMRM paths), and
the registry lists it for fit_solomon_glm(), so the citing article's table
shows it. A known-result test reproduces their worked example (slope
.55264, SSW 62.39, F = 21.01; interaction F = 0.21 from the data, printed
.22; adjusted means 12.45 and 7.55) and the 2 x 2 analysis (Table 2).
Williams and Newman (1982), a six-group single model without person
vectors, is added to the history article as a published answer to
Campbell and Stanley's "no single procedure" remark; the history article
also gains a 1990 section with the reproduction, and its timeline labels
no longer overlap.

#106. Dukes, Ullman, and Stein (1995) is cited as a published precedent
for the latent-variable analysis in the SEM article (new section: three
two-group models, loadings tested and intercepts imposed, no interaction
test, classroom means), the methods guide, the coverage article, and the
references. No SEM code changes.

#109. New data set waltonbraver1988 (Table 3, p. 153) with data-raw code,
a help page of known results, and a known-result test of the published
Tests A, D, E, H, and I, the pretest main effect, the 1988 path, and the
power remark. A second test reproduces Tests E and H of Sawilowsky and
Markman's counterexample, read in its 1988 ERIC version (ED316556), and
shows that its printed error entry 1200.04 is a misprint. The classic
vignette gains a section on both worked examples. ROADMAP no longer calls
the historical workflow validated: the computations reproduce, the
Monte Carlo rates only in part.

All new works are in references.Rmd, the coverage article (rows and
references), and each article that cites them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
?waltonbraver1988: the footnote on p. 153 is now paraphrased in full
(conditional on reaching the step and on the null hypothesis there,
offered because the experiment-wise rate is hard to specify in advance);
the history article's version is corrected the same way. The power remark
now gives the printed "p > .07" and the exact .076 separately.

#105: the GLM vignette no longer reads as if the package avoids the zero
coding Newman et al. (1990) cautioned against; like the help page, it says
the four contrasts do not depend on it and the `pretested` coefficient
does. ?fit_solomon_glm and the methods guide print their interaction
restriction, b1 = b3 + b2 - b4 (p. 98). The help page, coverage row, and
NEWS claim only what the known-result test reproduces (slope, SSW, and the
treatment and interaction F, printed .22); the test now also checks that
equation 7 has the package's fitted values, that the restricted models
give the printed SS7, SS9, SS10, and SS11, that the interaction and
treatment restrictions equal the squared t of the matching contrasts, and
the pretesting row (F = .36). fit_solomon_glm() is no longer registered
with newman1990: its report cites Newman et al. only with a pretest, so
the citing table no longer lists it as core, and a test guards that
contract. "How to Cite solomonR" explains when Newman et al. (1990) is
cited and adds Williams and Newman (1982), with references.

History: Solomon (1949, p. 146) is paraphrased rather than closely
echoed. Coverage: the Williams and Newman row cites pp. 83-89 with
Table 4; Sawilowsky and Markman's Test I computation is marked as a
reconstruction from their z values here, in references.Rmd, the classic
vignette, and the test comment.

#106: the SEM article names what solomonR shares with Dukes et al. (1995)
(multiple-group mean structure, loadings tested before latent means,
indicator means held equal, and the equal pretest-to-posttest path that
is the latent ANCOVA's common slope), and the SEM article, coverage, and
references list all four planned elements under #117.

ROADMAP credits #51 to PR #76 and leaves #109's PR number to be added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JUhalt JUhalt added this to the v1.0.0 milestone Oct 4, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JUhalt and others added 5 commits October 4, 2026 07:19
NEWS: this branch's sections go under the development heading, above
the 0.8.1 section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pretest is now centered at the pretested participants' mean (#104),
so the attribution text of this branch is updated: ?fit_solomon_glm,
the methods guide, the GLM vignette, and NEWS say that the pretested
coefficient compares the groups at that mean, where Newman et al.
(1990, p. 101) took their adjusted means, and that their caution about
a pretest of 0 applies to the uncentered coding of the paper. The
methods guide's section on the model, moved by this branch to the
published proposals, gains master's pretest effects; the old extension
section is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vignettes/articles/sem.Rmd: master's section on reporting latent models
comes first, after the invariance example it refers to, then this
branch's section on Dukes et al. (1995). NEWS and WORDLIST keep both
sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NEWS: this branch's sections go first under the development heading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NEWS: this branch's sections go first under the development heading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.0] Credit the published origin of the unified model (Newman, Benz, & Williams, 1990; Williams & Newman, 1982)

1 participant