Final small fixes#13
Merged
Merged
Conversation
Metric rename (batch.py, monte_carlo.py, export.py, batch_results.py): false_positive_rate → compliant_audit_fraction detection_rate → detection_rate_given_audit Avoids collision with the input config parameter false_positive_rate (alpha) and clarifies that the metric was conditional on audit, not population-level. RNG fix (market.py, game_loop.py): fixed-price over-subscription path used global random.sample(); now accepts and threads the caller's seeded rng so exact reproduction is possible across all audit steps. Scenario files: scenario_5_ratchet → scenario_5_reputation_ratchet scenario_7_oscillation → scenario_6_enforcement_cycles scenario_6_lawless deleted Sweep configs updated to match. Adds scripts/generate_figure_data.py to regenerate compliance_ratchet.csv / compliance_oscillation.csv. Minor doc fixes: AuditConfig p_catch formula (was missing p_w, p_m terms); game_loop docstring six-phase → seven-phase; Makefile figure-data target. Also move type: ignore[misc] to lambda definition line (pre-existing mypy false negative caused by comment being on the wrong line of a multi-line expr). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove generate_figure_data.py from tracking (local tooling, gitignored) - Remove figure-data Makefile target that referenced it - Update .agents/ docs: detection_rate → detection_rate_given_audit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Merge scenario 4 (dynamic) + 5 (reputation ratchet) into scenario 4 "Feedback-Driven Compliance" with weaker params (base_prob=0.20, penalty=$50M) — still converges to ~97% compliance - Rename scenario 6 → 5 (enforcement cycles) - Rename sweep files: lawless→minimal, maxwell→smart - Replace all remaining lawless/crisis/maxwell references in code - Add PR.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JTuffy
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from code review of #11: seeded RNG bug, misleading metric names, and scenario cleanup.
false_positive_rate→compliant_audit_fraction(no longer clashes with the config param),detection_rate→detection_rate_given_audit(clarifies it's conditional on audit). Updated everywhere — schemas, MC service, CSV/Excel export, dashboard UI.p_catchformula in AuditConfig, "six-phase" → "seven-phase" in game loopLet me know what you think about the tweaks to the dynamic scenario. Can always revert, I just figured it would be good to compare the reputation-driven compliance with the audit feedback driven compliance in scenario 5.