Conversation
Owner
Author
|
This means some tests started failing, because the exact errors have been shifted around by the difference in round-off error. As a result they were made slightly less stringent. |
Owner
Author
|
In the original Fortran code by Fukushima the compiler is allowed to pick which instructions to use. E.g. if the user sets "-march=native" it may use fused multiply-add instructions. As a result their use shouldn't conflict with how the algorithm is set up. Though it is possible that the minimax algorithm that determined the coefficients for the polynomials would have determined different coefficients if it ran with fma instrucitons (I don't know if it did). |
Owner
Author
|
I will need to determine if the fma instructions break the minimax approximation before I merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
polynomialfunction use fused multiply-add instructions when the target CPU supports them. This speeds up function execution slightly in those cases.