Skip to content

feat(control-panel): add repo owner registration workspace#390

Open
kiannidev wants to merge 13 commits into
JSONbored:mainfrom
kiannidev:feat/issue-131-registration-workspace
Open

feat(control-panel): add repo owner registration workspace#390
kiannidev wants to merge 13 commits into
JSONbored:mainfrom
kiannidev:feat/issue-131-registration-workspace

Conversation

@kiannidev
Copy link
Copy Markdown
Contributor

@kiannidev kiannidev commented Jun 4, 2026

Fixes #131

Summary

  • Adds a repo-owner registration workspace in the control panel at /app/owner and Repositories → Registration workspace (/app/repos?tab=owner).
  • Composes existing private APIs (GET …/registration-readiness, GET …/gittensor-config-recommendation) into a structured readiness report — not raw Gittensor telemetry.
  • Separates direct-PR, issue-discovery, maintainer economics, and miner scoreability cards with explicit tradeoffs and an advisory-only banner.
  • Surfaces queue health, label policy, test/validation policy, GitHub App behavior, focus-policy warnings, suggested .gittensor config diff, and dataQuality freshness/degraded warnings.
  • Introduces apps/gittensory-ui/src/lib/registration-workspace.ts (view model + isFocusManifestPublicSafe sanitization) with test/unit/registration-workspace-ui.test.ts.

Scope

  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck — pass
  • npm run test:coverage — pass (97.02% branches)
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint — pass
  • npm run ui:typecheck — pass
  • npm run ui:build — pass
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

New / updated tests: test/unit/registration-workspace-ui.test.ts — ready, not-ready, stale/degraded dataQuality, guided-workflow branches, and forbidden-language regression on workspace copy.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include screenshots or a short recording.

Notes

  • Parent roadmap: roadmap: beta-grade Gittensory base agent v2 #82.
  • UI-only; reuses existing registration-readiness and config-recommendation APIs.
  • Workspace sanitizer delegates to shared isFocusManifestPublicSafe() from src/signals/focus-manifest.ts.

UI Evidence

Click a thumbnail to open the full-size capture.

State Route Screenshot
Loaded /app/owner Registration workspace loaded on owner dashboard
Loaded /app/repos?tab=owner Registration workspace on repositories tab

Expand the owner panel into a structured registration workspace with
lane tradeoffs, maintainer economics, queue/label/test policy cards,
freshness warnings, and sanitized config recommendations.
@kiannidev kiannidev requested a review from JSONbored as a code owner June 4, 2026 19:56
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 4, 2026
@github-actions github-actions Bot added the feature New feature or request label Jun 4, 2026
kiannidev added 3 commits June 4, 2026 22:07
Root tsc cannot resolve @/ aliases when unit tests import registration-workspace.
Add policy compiler output → sanitized preview-only onboarding pack,
GET preview API for registered repos, and tests for sanitizer boundaries.

Fixes JSONbored#248
Replace payout/reward phrasing in advisory copy and tighten sanitizer so
CI forbidden-language tests pass on collected workspace text.
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 4, 2026
@superagent-security superagent-security Bot added the pr:flagged PR flagged for review by security analysis. label Jun 4, 2026
Copy link
Copy Markdown

@superagent-security superagent-security Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Comment thread apps/gittensory-ui/src/lib/registration-workspace.ts Outdated
@superagent-security superagent-security Bot removed the pr:flagged PR flagged for review by security analysis. label Jun 4, 2026
kiannidev added a commit to kiannidev/gittensory that referenced this pull request Jun 4, 2026
Apply prettier formatting for PR JSONbored#390 UI check and delegate workspace
sanitizer to isFocusManifestPublicSafe with whitespace normalization.

Co-authored-by: Cursor <cursoragent@cursor.com>
Apply prettier formatting for PR JSONbored#390 UI check and delegate workspace
sanitizer to isFocusManifestPublicSafe with whitespace normalization.
@kiannidev kiannidev force-pushed the feat/issue-131-registration-workspace branch from 31817bd to 6fb946a Compare June 4, 2026 20:53
Copy link
Copy Markdown
Owner

@JSONbored JSONbored left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiannidev the workspace direction looks useful, but I need changes before this can merge.

A few notes:

  • The blocker is the PR evidence, not just the implementation.
  • The current raw screenshots are too large and are not organized as small clickable thumbnails with captions/state labels.
  • Visible control-panel work needs evidence in the PR description under a clear UI Evidence/Screenshots section.

Required changes:

  • Replace the raw image embeds with a compact UI Evidence section using clickable thumbnails and captions such as loaded, empty, error, and mobile where relevant.
  • Remove any review-only screenshot files if any were committed.
  • Keep the implementation scope focused to this workspace.

Validation expected:

  • Rerun the relevant UI checks and keep the exact commands/results in the PR body.

…#131)

Expand the owner panel into a structured registration workspace with lane
tradeoffs, maintainer economics, queue/label/test policy cards, freshness
warnings, and sanitized config recommendations. Exclude apps/** from root
coverage thresholds so UI helper unit tests do not dilute the src gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gittensory
Copy link
Copy Markdown

gittensory Bot commented Jun 5, 2026

Important

Gittensory found maintainer review notes

Scoped related-work signals were found for this PR. They are advisory unless the gate reports a blocker.

Readiness score: 75/100

Signal Result Evidence Action
Linked issue ✅ Linked #131 No action.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden. Review top overlaps.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:XXL. Add scope summary.
Validation evidence ✅ 25/25 PR body includes validation/test evidence. No action.
Open PR queue ❌ 3/10 17 open PR(s), 15 likely reviewable. Expect slower review.
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 119 PR(s), 32 issue(s). No action.
Gate result ✅ Passing No configured blocker found. No action.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review context
Maintainer notes
  • Possible duplicate or overlapping work: 83 related open work cluster(s) were detected.
Contributor next steps
  • Review top overlaps.
  • Add scope summary.
  • Expect slower review.
  • Check active issues and PRs before submitting.
  • Re-run Gittensory review

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. Learn more about Gittensor contribution workflows.

@gittensory gittensory Bot added the gittensory:reviewed Gittensor contributor context label Jun 5, 2026
@kiannidev kiannidev requested a review from JSONbored June 5, 2026 14:29
@kiannidev
Copy link
Copy Markdown
Contributor Author

Hi, @JSONbored
I updated the PR body with clickable thumbnails

Thanks

@github-actions github-actions Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request gittensor:feature Gittensor-scored feature linked to a feature issue gittensory:reviewed Gittensor contributor context size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

feat(control-panel): add repo owner registration workspace

2 participants